Enable git submodules cloning when using go-git #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
enhancement
Member
|
While this does technically work, I am wondering how easy it will be to setup for our users. As we upsert our private key as a deploy key in the bootstrap process, and a deploy key can not exist in multiple repositories, the setup for private submodules will likely either require HTTP/S credentials with a broad(er) access scope, or a private key from a (bot) user. |
Member
Author
|
@hiddeco I don't think this is our concern, people can use HTTPS when bootstrapping or provide a SSH key that belongs to a bot. I would not recommend sub-modules to anyone, but seems that some flux1 users depend on this feature, with this they can migrate as they were using HTTPS anyway. |
hiddeco
approved these changes
Mar 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several Git sub-modules issues were fixed in go-git v5.3.0 (released today) so we can enable this feature in source-controller.
This PR addresses fluxcd/flux2#326