Skip to content

Enable git submodules cloning when using go-git #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanprodan merged 1 commit into from
Mar 29, 2021
Merged

Enable git submodules cloning when using go-git #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/spec/v1beta1/gitrepositories.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,10 @@ and also impact the traffic costs.
To be able to support Azure DevOps a compromise solution was built, giving the user the
option to select the git library while accepting the drawbacks.

| Git Implementation | Shallow Clones | V2 Protocol Support |
|---|---|---|
| 'go-git' | true | false |
| 'libgit2' | false | true |
| Git Implementation | Shallow Clones | Git Submodules | V2 Protocol Support |
|---|---|---|---|
| 'go-git' | true | true | false |
| 'libgit2' | false | false | true |

Pull the master branch from a repository in Azure DevOps.

Expand Down Expand Up @@ -318,7 +318,7 @@ data:
password: <BASE64>
```

## HTTPS self-signed certificates
### HTTPS self-signed certificates

Cloning over HTTPS from a Git repository with a self-signed certificate:

Expand Down
8 changes: 4 additions & 4 deletions pkg/git/gogit/checkout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (c *CheckoutBranch) Checkout(ctx context.Context, path, url string, auth *g
SingleBranch: true,
NoCheckout: false,
Depth: 1,
RecurseSubmodules: 0,
RecurseSubmodules: extgogit.DefaultSubmoduleRecursionDepth,
Progress: nil,
Tags: extgogit.NoTags,
CABundle: auth.CABundle,
Expand Down Expand Up @@ -99,7 +99,7 @@ func (c *CheckoutTag) Checkout(ctx context.Context, path, url string, auth *git.
SingleBranch: true,
NoCheckout: false,
Depth: 1,
RecurseSubmodules: 0,
RecurseSubmodules: extgogit.DefaultSubmoduleRecursionDepth,
Progress: nil,
Tags: extgogit.NoTags,
CABundle: auth.CABundle,
Expand Down Expand Up @@ -131,7 +131,7 @@ func (c *CheckoutCommit) Checkout(ctx context.Context, path, url string, auth *g
ReferenceName: plumbing.NewBranchReferenceName(c.branch),
SingleBranch: true,
NoCheckout: false,
RecurseSubmodules: 0,
RecurseSubmodules: extgogit.DefaultSubmoduleRecursionDepth,
Progress: nil,
Tags: extgogit.NoTags,
CABundle: auth.CABundle,
Expand Down Expand Up @@ -173,7 +173,7 @@ func (c *CheckoutSemVer) Checkout(ctx context.Context, path, url string, auth *g
RemoteName: git.DefaultOrigin,
NoCheckout: false,
Depth: 1,
RecurseSubmodules: 0,
RecurseSubmodules: extgogit.DefaultSubmoduleRecursionDepth,
Progress: nil,
Tags: extgogit.AllTags,
CABundle: auth.CABundle,
Expand Down