Skip to content

Conversation

@IridiumOxide
Copy link
Contributor

@IridiumOxide IridiumOxide commented Sep 30, 2022

Closes: GH-5
Closes: GH-6


This change is Reviewable

@IridiumOxide IridiumOxide force-pushed the java-sdk-impl branch 4 times, most recently from 6fc5b56 to 33f2359 Compare September 30, 2022 23:39
Copy link
Contributor

@kwapik kwapik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If supporting of Java 8 is much of a problem, just drop it. We can support Java > 11 for start.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @IridiumOxide)


src/main/java/com/fluxninja/aperture/example/App.java line 22 at r1 (raw file):

    public static void main(String[] args) {
        final String agentHost = "aperture-agent.aperture-system.svc.cluster.local";

NIT: You can change this to match playground deployment i.e. aperture-agent.aperture-agent.svc.cluster.local


src/main/java/com/fluxninja/aperture/sdk/ApertureSDK.java line 67 at r1 (raw file):

    // TODO: find a way to get ip from header
    String ip = "192.168.0.1";

After reading our collector code - the feature_ip label is not requiread anymore, so you can scrape the whole IP thing.

Copy link
Contributor

@kwapik kwapik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IridiumOxide)

@IridiumOxide IridiumOxide merged commit f577744 into main Oct 3, 2022
@IridiumOxide IridiumOxide deleted the java-sdk-impl branch October 3, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example for SDK Complete implementation of SDK

3 participants