fix(compiler): keep intrinsics registered across recompilation (#119) - #121
Merged
Conversation
intrinsic-forms becomes a defonce. build.clj compiles magic.analyzer.intrinsics 13 entries before magic.intrinsics refills it, and the require graph forces that order, so the plain def rebound the registry to an empty atom and clojure.walk plus 11 compiler namespaces were emitted without intrinsics.
bootstrap-namespaces drops clojure.string, clojure.set, clojure.walk and the 9 clojure.tools.analyzer entries. The first three recompile to the committed bytes now the registry survives, the analyzer ones have no source under src/stdlib. check-drift byte-verifies 28 stdlib DLLs instead of 25.
skydread1
force-pushed
the
fix/intrinsic-registry-defonce
branch
from
August 4, 2026 05:54
77db1dc to
783b7bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
intrinsic-formsbecomes adefonce, so recompilingmagic.analyzer.intrinsicsmid-bootstrap no longer replaces the filled registry with a fresh empty atom.clojure.walkamong them, so itsmagic-unityExport andmagic-unity-dualcopies move too.refresh.clj's exclusion list drops from 21 entries to the 9 of theclojure.corefamily, socheck-driftbyte-verifies 28 stdlib DLLs instead of 25.clojure.walkfaster at run time, and one pre-existing inlining gap surfaced for its own issue.