fix(compiler): make loop binding-type inference deterministic#69
Merged
Conversation
Candidate types for loop bindings were reduced in hash-set iteration order, and best-type breaks ties by keeping the argument it saw first, so a tie-prone loop could infer different binding types across processes and emit different bytes from unchanged sources. Sort the candidate sets and best-type's common-ancestor seqs with an ordinal comparator before reducing, the same shape as reusable-type selection.
…erence-order fix (#68)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68