Skip to content

feat: expose reading residual posture#321

Merged
flyingrobots merged 2 commits intomainfrom
review/reading-artifact-wip
Apr 30, 2026
Merged

feat: expose reading residual posture#321
flyingrobots merged 2 commits intomainfrom
review/reading-artifact-wip

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

@flyingrobots flyingrobots commented Apr 30, 2026

Summary

Exposes richer reading residual posture through the WASM ABI and observation artifact path.

This adds explicit ABI-shaped residual posture variants:

  • complete
  • residual
  • plurality_preserved
  • obstructed

It also bumps the ABI epoch to 8 because ABI v7 was already published before these additional serialized variants were added.

What changed

  • Expands ReadingResidualPosture in echo-wasm-abi
  • Adds CBOR wire-name round-trip coverage for all residual posture variants
  • Wires internal warp-core observation residual posture through ABI conversion
  • Strengthens warp-wasm observation artifact assertions for:
    • observer plan metadata
    • parent basis posture
    • residual posture
  • Updates ABI/read-side docs to ABI v8

Verification

  • cargo fmt --all -- --check
  • cargo test -p echo-wasm-abi --lib
  • cargo test -p warp-core --lib observation
  • cargo test -p warp-wasm --lib --features engine
  • cargo clippy -p warp-core --all-targets -- -D warnings -D missing_docs
  • pnpm docs:build

Push hook also passed the repository full local critical gate.

Summary by CodeRabbit

  • New Features

    • Added new observation reading residual posture variants, enabling more granular distinction between different bounded outcome states.
  • Documentation

    • Bumped ABI wire-level contract to version 8.
    • Expanded reading envelope specification with explicit enumeration of components and new residual posture semantics.
    • Documented additional posture labels to help external consumers better distinguish outcome types.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0f9d7da3-d6b0-4520-a184-b2699a25d7d7

📥 Commits

Reviewing files that changed from the base of the PR and between a9dfb0b and 49c82b7.

📒 Files selected for processing (7)
  • crates/echo-wasm-abi/src/kernel_port.rs
  • crates/echo-wasm-abi/src/lib.rs
  • crates/warp-core/src/observation.rs
  • crates/warp-wasm/src/warp_kernel.rs
  • docs/BEARING.md
  • docs/spec/SPEC-0004-worldlines-playback-truthbus.md
  • docs/spec/SPEC-0009-wasm-abi.md

📝 Walkthrough

Walkthrough

The PR increments the WASM ABI contract version from 7 to 8, introduces three new ReadingResidualPosture enum variants (Residual, PluralityPreserved, Obstructed), and propagates these changes through ABI definitions, core observation logic, tests, and specification documentation.

Changes

Cohort / File(s) Summary
ABI Contract & Serialization
crates/echo-wasm-abi/src/kernel_port.rs, crates/echo-wasm-abi/src/lib.rs
Bumps ABI_VERSION from 7 to 8, expands ReadingResidualPosture with three new snake_case variants, and adds deterministic CBOR wire-format test verifying Text string encoding for each variant.
Core Observation Model
crates/warp-core/src/observation.rs
Extends ReadingResidualPosture enum from single Complete variant to four variants, updates to_abi mapping logic to translate each variant, and adds dedicated conversion test covering all enum variants.
Test Validation
crates/warp-wasm/src/warp_kernel.rs
Imports new ABI reading types and augments test assertions to explicitly verify reading field properties (observer plan, basis posture, residual posture) in observation artifacts.
Specification Documentation
docs/BEARING.md, docs/spec/SPEC-0004-worldlines-playback-truthbus.md, docs/spec/SPEC-0009-wasm-abi.md
Updates ABI version reference to 8, clarifies reading envelope as contractual component, and explicitly enumerates residual posture labels distinguishing bounded non-clean outcomes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • echo#306 — Modifies echo-wasm-abi/src/kernel_port.rs ABI surface, updates ABI_VERSION constant, and alters ABI-visible enum types with direct structural overlap.

Poem

🔮 Eight whispers now through ABI gates,
Four postures dance—complete and residual states,
What bounded reads once hid, now truth reveals,
The engine knows precisely what it feels.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary feature: exposing reading residual posture through the WASM ABI and observation artifact path.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch review/reading-artifact-wip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots
Copy link
Copy Markdown
Owner Author

PR feedback processing summary for 49c82b7.

Issue Source Outcome Addressing SHA
Actionable review comments CodeRabbit / PR comments / inline review comments None found. CodeRabbit reported: "No actionable comments were generated in the recent review." N/A
Docstring coverage warning in generated CodeRabbit pre-merge summary CodeRabbit generated summary Not a GitHub failing check and no line-level actionable request was opened. Repository rustdoc and missing_docs gates are passing for this PR. N/A
CI / det-gates GitHub checks All reported checks passing, including DET-001 Static Inspection. 49c82b7
Merge readiness Branch protection Blocked by required review policy, not by code or CI. N/A

No fix commits were added in this feedback pass.

@flyingrobots flyingrobots merged commit 9f6fa2c into main Apr 30, 2026
30 checks passed
@flyingrobots flyingrobots deleted the review/reading-artifact-wip branch April 30, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant