Skip to content

Accept Edict Target IR obstruction receipts#642

Merged
flyingrobots merged 2 commits into
mainfrom
cycle/641-edict-target-ir-receipt
Jul 5, 2026
Merged

Accept Edict Target IR obstruction receipts#642
flyingrobots merged 2 commits into
mainfrom
cycle/641-edict-target-ir-receipt

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Summary

  • Adds a narrow warp-core Edict echo.span-ir/v1 Target IR fixture bridge.
  • Accepts exactly one pre-step continueObstructed requirement with strict lowercase sha256: target-profile and Target IR digest references.
  • Emits deterministic attempt receipt objects bound to the supplied Target IR digest for fresh and stale basis facts.
  • Records the boundary in a design note, BEARING, and CHANGELOG.

Boundary

This is the Echo-side obstruction-strand fixture bridge after Edict PR #132. It separates artifact acceptance from execution-attempt receipt production and distinguishes obstructed attempts from invalid proposals and legal unselected counterfactuals.

It does not implement general Edict bundle admission, participant policy, Jim product semantics, scheduler counterfactual exploration, canonical Echo receipt bytes, receipt digests, XYPH settlement, or a target plugin registry.

RED

  • cargo test -p warp-core --test edict_target_ir_receipt_tests failed with unresolved imports for the missing Edict Target IR receipt bridge API.

GREEN

  • cargo test -p warp-core --test edict_target_ir_receipt_tests
  • cargo test -p warp-core --test contract_obstruction_taxonomy_tests
  • cargo check -p warp-core
  • cargo clippy -p warp-core --lib -- -D warnings
  • cargo clippy -p warp-core --test edict_target_ir_receipt_tests -- -D warnings
  • cargo fmt --all -- --check
  • pnpm exec markdownlint-cli2 CHANGELOG.md docs/BEARING.md docs/design/edict-target-ir-obstruction-receipt-bridge.md
  • scripts/check_spdx.sh
  • scripts/check-no-app-nouns-in-core.sh
  • git diff --check

Pre-push also passed:

  • cargo test -p warp-core --lib (565 tests)
  • cargo test -p warp-core --test edict_target_ir_receipt_tests
  • Prettier check for touched Markdown

Closes #641.
Supports #583, #589, and #640.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@flyingrobots, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5a069348-9ee2-4a6d-8971-c8a7023f909a

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef21d2 and f7c3c60.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • CHANGELOG.md
  • crates/warp-core/src/edict_target_ir.rs
  • crates/warp-core/src/lib.rs
  • crates/warp-core/tests/edict_target_ir_receipt_tests.rs
  • docs/BEARING.md
  • docs/design/edict-target-ir-obstruction-receipt-bridge.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/641-edict-target-ir-receipt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flyingrobots

Copy link
Copy Markdown
Owner Author

Audit follow-up after CI failure:

Item Result
Root cause Cargo Audit flagged RUSTSEC-2026-0190 for anyhow 1.0.100.
Fix Lockfile-only update from anyhow 1.0.100 to 1.0.103 in f7c3c601.
Scope No Rust source or behavior changes in the audit fix commit.

Local GREEN after the lockfile update:

bash scripts/run_cargo_audit.sh
cargo check -p warp-core
cargo test -p warp-core --test edict_target_ir_receipt_tests

@flyingrobots flyingrobots merged commit 5c968a4 into main Jul 5, 2026
36 checks passed
@flyingrobots flyingrobots deleted the cycle/641-edict-target-ir-receipt branch July 5, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept Edict Target IR obstruction fixture and emit Echo receipt

1 participant