Add editor projection CLI - #115
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughIntroduces a Changesedict CLI project operation
Estimated code review effort: 4 (Complex) | ~75 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant CLI as edict-cli
participant CompilerContext
participant ProjectionRecords
Client->>CLI: JSONL request (operation: project)
CLI->>CLI: parse_request / parse_settings (attach command)
CLI->>CLI: validate_operation_settings / validate_project_target
CLI->>CompilerContext: build from compilerContext/target facts
CompilerContext-->>CLI: core/target-ir facts, or blocked/failed reason
CLI->>ProjectionRecords: emit syntax, diagnostics, core, target-ir records
ProjectionRecords-->>Client: stdout JSONL projection records + status
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex self-review found two issues that should be addressed before this projection contract lands.
No additional issues found in the changed projection schemas, topic-shelf rows, or whitespace checks during this pass. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a8f8dad19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Testing
|
|
Resolved the self-review findings in commit
RED: GREEN:
Self-review after the fix found no additional actionable issues in the final diff. |
Code Lawyer Activity SummaryConsolidated audit queue for this pass. All actionable PR review threads are resolved, and the local gate is green on head
Verification evidence:
No new unresolved self-discovered issues remain from the |
Self-Discovered Issue Disclosure@codex please confirm the self-discovered audit item below is fully addressed.
|
Summary
Testing
|
Summary
Adds the Edict-side editor projection surface for dirty
.edictbuffers. The CLI now supportsoperation: "project"over existing JSONL stdin/source records and can emit syntax, diagnostics, Core, and Target IR projection records.Projection review JSON is display data for editor tooling. Canonical digest fields are computed from the existing Core and Target IR canonical encoders; this PR does not define Echo execution, admission execution, bundle assembly behavior, or canonical manifest bytes.
What changed
project,emit, explicit compiler facts, and explicit target facts.RED
cargo test -p edict-cli project_failed before implementation becauseprojectwas unsupported.cargo test -p edict-cli project_syntax_only_does_not_run_authoritative_compiler_pathfailed during self-review because syntax-only projection still counted hidden parse diagnostics.GREEN
cargo test -p edict-clicargo xtask contract-checkcargo xtask verifyDocs impact
Updated CLI and developer-tooling topic shelves, projection schemas, xtask schema guards, and CHANGELOG.
Issue
No issue closes in this PR.