Publish canonical external request application artifacts by flyingrobots · Pull Request #177 · flyingrobots/edict

flyingrobots · 2026-07-30T00:39:29Z

Summary

publish exact compiler-owned Core and Target IR for explicit external-action builds
validate root-reachable, digest-bound request authority without invoking provider components
bind request-only lawpack profiles to exact budgets and target configuration

Closes #176.

Plain-English Walkthrough

[CLAIM: explicit route] buildKind: externalAction selects a separate public build route while the omitted field preserves the existing executable-operation default. Source

[CLAIM: compiler ownership] The route writes the canonical Core and Target IR bytes returned by Edict encoders, before any provider-component selection or invocation. Source

[CLAIM: authority closure] Publication requires at least one typed request, refuses callable target steps, binds operation authority by an exact root-reachable manifest digest, and rejects disconnected lawpacks. Request gate Root closure

[CLAIM: no callable grant] A request-only lawpack profile must supply a budget and target configuration while carrying no semantic effects; compiler facts retain the profile-to-budget association. Source

[CLAIM: reproducible closure] The owning generator builds and checks the manifest, exports, adapter, configuration, source, Core, and Target IR as one exact corpus. Source

flowchart LR
    S[Exact Edict source] --> C[Canonical Core]
    L[Root-reachable lawpack closure] --> C
    C --> T[Canonical Target IR]
    T --> G{Request-only gate}
    G -->|accepted| O[core.cbor and target-ir.cbor]
    G -->|callable or unbound| R[typed refusal]
    P[Provider components] -. not invoked .-> G

Validation

cargo xtask verify
request-only profile budget mismatch regression
disconnected lawpack and manifest-digest authority regressions
exact Echo target-profile byte comparison
Echo production vocabulary scan: no Graft, Hello Echo, greeting, or workspace-snapshot terms

flyingrobots · 2026-07-30T00:39:37Z

@coderabbitai review

flyingrobots · 2026-07-30T00:39:37Z

@codex please review

coderabbitai · 2026-07-30T00:39:44Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-07-30T00:39:51Z

Summary by CodeRabbit

New Features
- Added request-only application builds using buildKind: externalAction.
- Builds now publish canonical Core and Target IR artifacts without invoking providers or performing external actions.
- Added reproducible workspace snapshot build support with exact capability, budget, and target configuration validation.
Bug Fixes
- Prevented invalid mixed callable/request builds and capability substitutions.
- Replaced output artifacts transactionally and removed stale executable-build outputs.
Documentation
- Added CLI guidance, requirements, test plans, schemas, and workspace snapshot examples for the new build mode.

Walkthrough

Adds an explicit externalAction application-build route that validates request-only Target IR, publishes canonical Core and Target IR artifacts transactionally, extends lawpack adapter profiles with request-only bindings, and adds reproducible workspace-snapshot fixtures and coverage.

Changes

External-action application build

Layer / File(s)	Summary
Request-only profile contract `crates/edict-syntax/src/lawpack_adapter.rs`, `docs/abi/...`, `fixtures/provider-contracts/...`, `crates/edict-syntax/tests/lawpack.rs`	Operation profiles support optional budget and target-configuration references; empty semantic-effect profiles require exact bindings and are validated accordingly.
Workspace snapshot golden closure `xtask/src/lawpack_goldens.rs`, `fixtures/lawpack/workspace-snapshot/*`, `fixtures/providers/echo-target-profile/README.md`	Generates and records the manifest, adapter, configuration, source, Core, Target IR, and digest artifacts for a request-only workspace snapshot.
Application build routing and validation `crates/edict-cli/src/application_build.rs`, `docs/topics/cli/README.md`, `docs/topics/external-action-requests/README.md`, `docs/REQUIREMENTS.md`, `README.md`, `CHANGELOG.md`	Adds `buildKind`, validates typed external-action requests, rejects callable-step mixtures and capability substitution, and bypasses provider setup for the external-action route.
Paired artifact publication and coverage `crates/edict-cli/src/application_build.rs`	Stages, atomically publishes, rolls back, and removes obsolete output pairs while testing validation, determinism, stale-output cleanup, and failure behavior.
Lawpack and external-request contract documentation `docs/topics/lawpacks/*`, `docs/topics/README.md`	Documents request-only profile requirements, reproducible workspace-snapshot artifacts, and the boundary before provider execution.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant build_application
  participant LawpackAdapter
  participant TargetIrArtifact
  participant OutputPublisher
  Client->>build_application: submit application manifest
  build_application->>LawpackAdapter: validate lawpack closure and profile bindings
  build_application->>TargetIrArtifact: compile and lower source
  TargetIrArtifact-->>build_application: canonical Core and Target IR
  build_application->>OutputPublisher: publish core.cbor and target-ir.cbor

Possibly related PRs

flyingrobots/edict#170 — Extends the same application-build and adapter-validation boundaries.
flyingrobots/edict#175 — Introduces the external-action request structures consumed by this build route.

Poem

A request takes shape in canonical light,
Core and Target IR lock tight.
No callable step may slip the gate,
Old outputs vanish; pairs translate.
Goldens hum where digests align.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR matches `#176`: it adds the externalAction route, validates request-only closure, emits canonical Core/Target IR, and preserves executable-operation builds.
Out of Scope Changes check	✅ Passed	The added docs, fixtures, tests, and goldens all support the external-request build feature and do not appear unrelated.
Title check	✅ Passed	The title clearly summarizes the main change: publishing canonical external-request application artifacts.
Description check	✅ Passed	The description directly matches the changeset, covering external-action builds, request-only profiles, and canonical artifact publication.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bb1cbc5d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderabbitai

Actionable comments posted: 9

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/edict-cli/src/application_build.rs`:
- Around line 455-483: Clarify or enforce the operation-coordinate invariant
used by validate_external_action_artifacts: the current rsplit_once('@') and
id-prefix checks incorrectly reject valid lawpack operations and classify
malformed coordinates as closure substitution. Either document and validate this
coordinate schema at the lawpack ABI boundary, or change the substituted
detection to use digest-only binding and report malformed coordinates through a
separate validation error.
- Around line 1479-1549: Update the rollback publication flow around the
output-building function to derive published recovery entries from the `outputs`
slice rather than assuming exactly two items. Change the `outputs` and
`obsolete` parameters from fixed-size arrays to slices, size `destinations` from
the slice lengths, and replace the hard-coded reverse indices with a reverse
iteration over `outputs` zipped to the corresponding published recovery entries
and staged paths. Preserve publishing in reverse order and keep obsolete
recoveries excluded from publication.

In `@crates/edict-syntax/src/lawpack_adapter.rs`:
- Around line 65-70: Add concise doc comments to the budget_obligation and
target_configuration fields of LawpackAdapterOperationProfile, documenting that
both are mandatory when semantic_effects is empty (request-only profiles) and
optional otherwise. Keep the validation behavior in validate_adapter_closure
unchanged.

In `@crates/edict-syntax/tests/lawpack.rs`:
- Around line 275-410: Extract the duplicated request-only adapter construction
from the three tests into a shared request_only_adapter helper, parameterized by
optional budgetObligation and whether to include targetConfiguration. Update
request_only_profile_supplies_budget_without_callable_effect_authority,
request_only_profile_requires_an_exact_budget_obligation, and
request_only_profile_requires_an_exact_target_configuration to use the helper
while preserving each test’s existing setup and assertions.

In `@docs/REQUIREMENTS.md`:
- Line 71: Update the ID Scheme section of REQUIREMENTS.md to declare the
EDICT-CLI domain alongside the existing legal prefixes before retaining the new
EDICT-CLI-EXTERNAL-REQUEST-BUILD-001 requirement row. Keep the row’s identifier
unchanged and ensure the domain declaration explicitly covers CLI requirements.

In `@docs/topics/cli/README.md`:
- Around line 79-90: The request-only route documentation must explain why the
example still requires providerPackage: it is used only to load and verify the
provider manifest and target-profile artifact, not to invoke a provider
component. Add this clarification near the example and state that omitting
providerPackage causes InvalidApplicationConfig, while preserving the existing
no-component-host behavior.

In `@docs/topics/cli/test-plan.md`:
- Line 45: Reconcile the CLI-REQ-015 status with its available evidence: because
CLI-TP-028 remains planned and no automated executable-provider fixture exists,
do not mark the executable build route implemented based only on CLI-TP-027.
Either reference a test that witnesses the full lowerer/verifier/provider-host
and output crossing, or restore the prior status and leave the externalAction
scope unchanged.

In `@docs/topics/external-action-requests/test-plan.md`:
- Line 71: Add a Fixtures-table row documenting the publication-determinism
corpus seed used by
external_action_pair_publication_is_deterministic_for_a_fixed_seed_corpus,
including the STRESS_SEED value from application_build.rs. Ensure EXTREQ-TP-018
and the Determinism Obligations section reference this recorded seed explicitly.

In `@fixtures/providers/echo-target-profile/README.md`:
- Around line 6-17: Convert the Provenance evidence block in the README from
bullet points to a two-column table with consistent labels and values for
repository, source commit, source path, generator identity, Edict domain-framed
identity, and raw file SHA-256; preserve all existing values unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 48353942-39bf-45eb-ab3a-480aa897f674

📥 Commits

Reviewing files that changed from the base of the PR and between eb873d3 and 4bb1cbc.

⛔ Files ignored due to path filters (1)

fixtures/providers/echo-target-profile/generated/primary/target-profile.echo-dpo.cbor is excluded by !**/generated/**

📒 Files selected for processing (32)

CHANGELOG.md
README.md
crates/edict-cli/src/application_build.rs
crates/edict-syntax/src/lawpack_adapter.rs
crates/edict-syntax/tests/lawpack.rs
docs/REQUIREMENTS.md
docs/abi/edict-lawpack-adapter.cddl
docs/topics/README.md
docs/topics/cli/README.md
docs/topics/cli/test-plan.md
docs/topics/external-action-requests/README.md
docs/topics/external-action-requests/test-plan.md
docs/topics/lawpacks/README.md
docs/topics/lawpacks/test-plan.md
fixtures/lawpack/workspace-snapshot/README.md
fixtures/lawpack/workspace-snapshot/adapter.cbor
fixtures/lawpack/workspace-snapshot/adapter.sha256
fixtures/lawpack/workspace-snapshot/exports.cbor
fixtures/lawpack/workspace-snapshot/exports.sha256
fixtures/lawpack/workspace-snapshot/manifest.cbor
fixtures/lawpack/workspace-snapshot/manifest.sha256
fixtures/lawpack/workspace-snapshot/observe-workspace.core.cbor
fixtures/lawpack/workspace-snapshot/observe-workspace.core.sha256
fixtures/lawpack/workspace-snapshot/observe-workspace.edict
fixtures/lawpack/workspace-snapshot/observe-workspace.target-ir.cbor
fixtures/lawpack/workspace-snapshot/observe-workspace.target-ir.sha256
fixtures/lawpack/workspace-snapshot/request-profile-configuration.cbor
fixtures/lawpack/workspace-snapshot/request-profile-configuration.sha256
fixtures/provider-contracts/v1/edict-provider-contracts.cddl
fixtures/provider-contracts/v1/manifest.json
fixtures/providers/echo-target-profile/README.md
xtask/src/lawpack_goldens.rs

📜 Review details

⏰ Context from checks skipped due to timeout. (3)

GitHub Check: rust msrv 1.94.0 (fmt · clippy · test)
GitHub Check: rust stable (fmt · clippy · test)
GitHub Check: supply-chain (cargo-deny)

🧰 Additional context used

📓 Path-based instructions (6)

**/*