Skip to content

Record dependency-satisfied review outcomes - #20

Merged
flyingrobots merged 4 commits into
mainfrom
task/19-dependency-satisfied-review-outcomes
Jul 29, 2026
Merged

Record dependency-satisfied review outcomes#20
flyingrobots merged 4 commits into
mainfrom
task/19-dependency-satisfied-review-outcomes

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Adds dependency-owned review disposition and bounded operator authorization to the operative loop and phase graph. Closes #19.

@flyingrobots

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@flyingrobots

Copy link
Copy Markdown
Owner Author

@codex please review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@flyingrobots, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c6d0521a-85ce-40a5-b470-04a39f149e17

📥 Commits

Reviewing files that changed from the base of the PR and between 65ee695 and f93e2ff.

📒 Files selected for processing (2)
  • docs/legacy/delivery-loop-prompt.md
  • docs/phase-graph.md

Walkthrough

The delivery-loop documentation adds SATISFIED_BY_DEPENDENCY, bounded operator-authorized remediation, and disposition-only closure. The phase graph models authorization state, transition rules, counter semantics, dependency assessment, and immutable escalation terminals.

Changes

Dependency-Satisfied Review Flow

Layer / File(s) Summary
Dependency outcome contract
docs/phase-graph.md, docs/legacy/delivery-loop-prompt.md
Dependency evidence and assessment fields support the gate-admissible SATISFIED_BY_DEPENDENCY outcome with required ownership, rationale, and consumer-change conditions.
Operator-authorized continuation
docs/phase-graph.md
Run state, effects, transitions, counters, and terminal binding define one bounded remediation pass or disposition-only continuation without resetting autonomous passes.
Legacy loop and call-interface rules
docs/legacy/delivery-loop-prompt.md, CHANGELOG.md
The legacy prompt and changelog describe named-finding authorization, non-mutating disposition-only closure, and revised autonomous pass semantics.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CodeLawyer
  participant DeliveryLoop
  participant OperatorAuthorization
  participant GitHub
  CodeLawyer->>DeliveryLoop: complete autonomous review passes
  DeliveryLoop->>OperatorAuthorization: request bounded continuation
  OperatorAuthorization->>DeliveryLoop: authorize named remediation or disposition
  DeliveryLoop->>GitHub: reply or resolve permitted named threads
  DeliveryLoop->>DeliveryLoop: re-evaluate merge gate
Loading

Poem

Two passes march, then limits ring,
A named command may change the thing.
Dependency truths now have a name,
Old terminals keep their frame.
No hidden edits, no budget flight—
Just bounded closure done right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the core change: recording dependency-satisfied review outcomes.
Description check ✅ Passed The description is directly about dependency-owned review disposition and operator authorization.
Linked Issues check ✅ Passed The docs changes cover the acceptance criteria: escalation, operator authorization, SATISFIED_BY_DEPENDENCY, and non-mutating disposition.
Out of Scope Changes check ✅ Passed No clear out-of-scope changes appear; the edits stay within the documented delivery-loop and phase-graph objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/phase-graph.md`:
- Around line 710-720: Update the motivating admitted record to explicitly
identify the Hello Echo consumer repository and issue `#17` alongside the existing
Echo issue 699 and PR 700 references. Revise the rationale if needed so it
clearly ties the closure to Echo `#700` and Hello Echo `#17`, while preserving the
existing outcome and consumer_change_required values.
- Around line 49-51: Define a canonical typed operator authorization record with
authenticated operator identity, unique authorization metadata, expiry, and
consumed state at docs/phase-graph.md lines 49-51; at lines 502-504, atomically
consume it before continuation and enforce mutual exclusion so remediation and
disposition-only continuation cannot both proceed or replay; mirror the same
authenticated, one-shot contract in docs/legacy/delivery-loop-prompt.md lines
242-263.
- Around line 493-495: The J55_ASSESS_THREADS transition currently permits
disposition-only mode to record BLOCKED and resolve the thread. In
docs/phase-graph.md lines 493-495, restrict the BLOCKED transition to
non-disposition-only modes and make disposition-only handling reject or escalate
without thread mutation; retain the existing prohibition as the operative rule
in docs/legacy/delivery-loop-prompt.md lines 186-193, requiring no direct change
there.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f0098b13-0ac7-478b-b8f0-8136f51fc061

📥 Commits

Reviewing files that changed from the base of the PR and between 5eb43a0 and 65ee695.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • docs/legacy/delivery-loop-prompt.md
  • docs/phase-graph.md
📜 Review details
🧰 Additional context used
🪛 LanguageTool
docs/legacy/delivery-loop-prompt.md

[style] ~72-~72: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...se-1 remediation iterations per task. - Max 2 autonomous Code Lawyer passes per PR....

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~73-~73: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...autonomous Code Lawyer passes per PR. - Max 1 operator-authorized additional remedi...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

🔇 Additional comments (2)
docs/legacy/delivery-loop-prompt.md (1)

32-40: LGTM!

Also applies to: 72-74, 203-204

CHANGELOG.md (1)

26-29: LGTM!

Comment thread docs/phase-graph.md Outdated
Comment thread docs/phase-graph.md
Comment thread docs/phase-graph.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65ee695d08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/phase-graph.md Outdated
Comment thread docs/phase-graph.md Outdated
Comment thread docs/phase-graph.md Outdated
Comment thread docs/phase-graph.md Outdated
@flyingrobots

Copy link
Copy Markdown
Owner Author

Merge gate open at f93e2ff.

  • CodeRabbit check: SUCCESS on current head.
  • Review threads: 0 unresolved by GraphQL.
  • Code Lawyer: 2 autonomous passes; all seven findings fixed and resolved; no operator pass.
  • Local validation: markdownlint-cli2 0 errors; git diff --check clean; worktree clean; published head exact.
  • Approval: main has 0 branch-protection rules. Solo-maintainer substitution applies for human approval.

Gate criteria 1-5 are satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Represent dependency-satisfied review outcomes in the delivery loop

1 participant