Hide generated proto stubs by default#4947
Merged
eapolinario merged 6 commits intomasterfrom Mar 8, 2024
Merged
Conversation
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4947 +/- ##
=======================================
Coverage 58.96% 58.97%
=======================================
Files 645 645
Lines 55506 55506
=======================================
+ Hits 32730 32732 +2
+ Misses 20177 20174 -3
- Partials 2599 2600 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
dosubot
bot
added
size:XS
eapolinario
changed the title
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* Add flyteidl/gen to .gitattributes Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * make generate to show a change Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Prepend forward slash to rule Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Hide copied swagger.json Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Move .gitattributes from flyteidl to root Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert test attribute change Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Showing generated code by default is usually not helpful. As documented in https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github, we can control how files are shown in diffs by default.
What changes were proposed in this pull request?
Add files under
flyteidl/gento.gitattributes. Do the same to the the copied swagger file and rst files.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link