Merged
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
* refactor: add error log when fail to add finalizer Signed-off-by: machichima <nary12321@gmail.com> * fix: handle err when status update failed Signed-off-by: machichima <nary12321@gmail.com> * fix: remove phase is terminal check rely fully on task action conditions Signed-off-by: machichima <nary12321@gmail.com> * refactor: add event when failed to build context in finalize Signed-off-by: machichima <nary12321@gmail.com> * fix: reconcile again after update CR Signed-off-by: machichima <nary12321@gmail.com> * fix: only update status if changed Signed-off-by: machichima <nary12321@gmail.com> * build: remove tracked Cargo.lock Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: machichima <nary12321@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
* Switch to pflags Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: machichima <nary12321@gmail.com> * Let it rain Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: machichima <nary12321@gmail.com> * mostly working Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: machichima <nary12321@gmail.com> * Add literal-JSON converter and TranslatorService for RSJF-compliant schema translation. The converter handles bidirectional conversion Add literal-JSON converter and TranslatorService for RSJF-compliant schema translation Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: machichima <nary12321@gmail.com> * Add ShortName field to TaskActionSpec and populate it through the queue and watch pipelines. Pass inputUri and runOutputBase as parameters to CreateRun instead of computing them after DB insert. Fix WatchActions to subscribe before Add ShortName field to TaskActionSpec and populate it through the queue and watch pipelines Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: machichima <nary12321@gmail.com> * fix: Pass parent name to Subscribe() and add TODO Signed-off-by: machichima <nary12321@gmail.com> * fix: clean-up main and add StopWatching call Signed-off-by: machichima <nary12321@gmail.com> * build: update CR fields Signed-off-by: machichima <nary12321@gmail.com> * feat: build local env with k3d and run successfully Signed-off-by: machichima <nary12321@gmail.com> * docs: add TODO in CreateRun Signed-off-by: machichima <nary12321@gmail.com> * docs: add brief development guide Signed-off-by: machichima <nary12321@gmail.com> * build: make gen Signed-off-by: machichima <nary12321@gmail.com> --------- Signed-off-by: machichima <nary12321@gmail.com> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Cherry pick #6902
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main