[V2]Sandbox for flyte v2 by popojk · Pull Request #6955 · flyteorg/flyte

popojk · 2026-03-02T07:25:13Z

Tracking issue

Related to #6922

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Build sandbox:

make sandbox-build

Run sandbox(add FLYTE_DEV=True arg to run in dev mode):

make sandbox-run

Set kubeconfig to v2 sandbox

export KUBECONFIG=~/.flyte/sandboxv2/kubeconfig

Run an example in flyte-sdk repo:

python examples/basics/devbox_one.py

sdk config.yaml:

admin:
  endpoint: dns:///localhost:30080
  insecure: True
logger:
  show-source: true
  level: 0

image:
  builder: local

task:
  domain: development
  project: testproject
  org: testorg

The task pods are good to go:

Labels

Please add one or more of the following labels to categorize your PR:

added: For new features.
changed: For changes in existing functionality.
deprecated: For soon-to-be-removed features.
removed: For features being removed.
fixed: For any bug fixed.
security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

main
- Flyte 2 WIP #6583
  - [V2]Sandbox for flyte v2 #6955 👈

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

pingsutw · 2026-03-02T17:56:20Z

charts/event.json

@@ -0,0 +1,5 @@
+{
+  "repository": {
+    "default_branch": "master"


What is this file? should we use v2 branch

Sorry this is an unused file, deleted.

pingsutw · 2026-03-02T18:02:58Z

Seeing this error when building the sandbox

 => CACHED [flytebuilder  6/17] COPY flytecopilot flytecopilot                                                                                                                          0.0s 
 => CACHED [flytebuilder  7/17] COPY flyteidl2 flyteidl2                                                                                                                                0.0s 
 => CACHED [flytebuilder  8/17] COPY flyteplugins flyteplugins                                                                                                                          0.0s 
 => CACHED [flytebuilder  9/17] COPY flytestdlib flytestdlib                                                                                                                            0.0s 
 => CACHED [flytebuilder 10/17] COPY gen gen                                                                                                                                            0.0s 
 => ERROR [flytebuilder 11/17] COPY queue queue                                                                                                                                         0.0s 
 => CACHED [flytebuilder 12/17] COPY runs runs                                                                                                                                          0.0s 
 => ERROR [flytebuilder 13/17] COPY state state                                                                                                                                         0.0s 
------                                                                                                                                                                                       
 > [flytebuilder 11/17] COPY queue queue:
------
------
 > [flytebuilder 13/17] COPY state state:
------

 1 warning found (use docker --debug to expand):
 - CopyIgnoredFile: Attempting to Copy file "gen" that is excluded by .dockerignore (line 18)                                                                                                
Dockerfile:21
--------------------
  19 |     COPY queue queue
  20 |     COPY runs runs
  21 | >>> COPY state state
  22 |     
  23 |     COPY go.mod go.sum ./
--------------------
ERROR: failed to build: failed to solve: failed to compute cache key: failed to calculate checksum of ref ekpscsqwcfa3y7gk4uz2qd27c::3cqpgmh56y7uxudzrdnq23t3i: "/state": not found

View build details: docker-desktop://dashboard/build/flyte-sandbox/flyte-sandbox0/lkbrhm8bgsq2h72sjruqmtdll
make[1]: *** [flyte] Error 1
make: *** [build-sandbox] Error 2

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk · 2026-03-03T02:44:37Z

Seeing this error when building the sandbox

 => CACHED [flytebuilder  6/17] COPY flytecopilot flytecopilot                                                                                                                          0.0s 
 => CACHED [flytebuilder  7/17] COPY flyteidl2 flyteidl2                                                                                                                                0.0s 
 => CACHED [flytebuilder  8/17] COPY flyteplugins flyteplugins                                                                                                                          0.0s 
 => CACHED [flytebuilder  9/17] COPY flytestdlib flytestdlib                                                                                                                            0.0s 
 => CACHED [flytebuilder 10/17] COPY gen gen                                                                                                                                            0.0s 
 => ERROR [flytebuilder 11/17] COPY queue queue                                                                                                                                         0.0s 
 => CACHED [flytebuilder 12/17] COPY runs runs                                                                                                                                          0.0s 
 => ERROR [flytebuilder 13/17] COPY state state                                                                                                                                         0.0s 
------                                                                                                                                                                                       
 > [flytebuilder 11/17] COPY queue queue:
------
------
 > [flytebuilder 13/17] COPY state state:
------

 1 warning found (use docker --debug to expand):
 - CopyIgnoredFile: Attempting to Copy file "gen" that is excluded by .dockerignore (line 18)                                                                                                
Dockerfile:21
--------------------
  19 |     COPY queue queue
  20 |     COPY runs runs
  21 | >>> COPY state state
  22 |     
  23 |     COPY go.mod go.sum ./
--------------------
ERROR: failed to build: failed to solve: failed to compute cache key: failed to calculate checksum of ref ekpscsqwcfa3y7gk4uz2qd27c::3cqpgmh56y7uxudzrdnq23t3i: "/state": not found

View build details: docker-desktop://dashboard/build/flyte-sandbox/flyte-sandbox0/lkbrhm8bgsq2h72sjruqmtdll
make[1]: *** [flyte] Error 1
make: *** [build-sandbox] Error 2

@pingsutw The build failed due to state and queue service are deleted. I just push a fix commit to it and the build is working now. Thanks!

machichima · 2026-03-03T09:33:17Z

Could you also paster the config for flyte-sdk in the PR description? Is it like so?

admin:
  endpoint: dns:///localhost:8090
  insecure: True
image:
  builder: local
task:
  domain: development
  project: testproject
  org: testorg

machichima · 2026-03-03T09:47:16Z

Got this error when running make build-sandbox

Downloading docker-registry from repo https://twuni.github.io/docker-registry.helm
Downloading kubernetes-dashboard from repo https://kubernetes-retired.github.io/dashboard/
Downloading minio from repo https://charts.bitnami.com/bitnami
Downloading postgresql from repo https://charts.bitnami.com/bitnami
Deleting outdated charts
mkdir -p manifests
kustomize build \
                --enable-helm \
                --load-restrictor=LoadRestrictionsNone \
                kustomize/complete > manifests/complete.yaml
Error: namespace transformation produces ID conflict: [{"apiVersion":"v1","kind":"Secret","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Secret","internal.config.kubernetes.io/previousNames":"kubernetes-dashboard-csrf","internal.config.kubernetes.io/previousNamespaces":"flyte"},"name":"kubernetes-dashboard-csrf","namespace":"flyte"}} {"apiVersion":"v1","kind":"Secret","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Secret","internal.config.kubernetes.io/previousNames":"kubernetes-dashboard-csrf","internal.config.kubernetes.io/previousNamespaces":"default"},"labels":{"app.kubernetes.io/instance":"flyte-sandbox","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/name":"kubernetes-dashboard","app.kubernetes.io/version":"2.7.0","helm.sh/chart":"kubernetes-dashboard-6.0.0"},"name":"kubernetes-dashboard-csrf","namespace":"flyte"},"type":"Opaque"}]
make[1]: *** [manifests] Error 1
make: *** [build-sandbox] Error 2

I think it's because we enable kubernetes-dashboard here

flyte/charts/flyte-sandbox/values.yaml

Lines 90 to 91 in 784cd7c

    
           kubernetes-dashboard: 
        
             enabled: true

And this will create the secret automathically:

flyte/docker/sandbox-bundled/manifests/dev.yaml

Lines 812 to 822 in 784cd7c

    
           apiVersion: v1 
        
           kind: Secret 
        
           metadata: 
        
             labels: 
        
               app.kubernetes.io/instance: flyte-sandbox 
        
               app.kubernetes.io/managed-by: Helm 
        
               app.kubernetes.io/name: kubernetes-dashboard 
        
               app.kubernetes.io/version: 2.7.0 
        
               helm.sh/chart: kubernetes-dashboard-6.0.0 
        
             name: kubernetes-dashboard-csrf 
        
           type: Opaque

Then we defined secret with same name in:

flyte/docker/sandbox-bundled/kustomize/dashboard-rbac.yaml

Lines 1 to 5 in 784cd7c

    
           apiVersion: v1 
        
           kind: Secret 
        
           metadata: 
        
             name: kubernetes-dashboard-csrf 
        
             namespace: flyte

this cause the conflict

popojk · 2026-03-03T12:19:26Z

Could you also paster the config for flyte-sdk in the PR description? Is it like so?

admin:
  endpoint: dns:///localhost:8090
  insecure: True
image:
  builder: local
task:
  domain: development
  project: testproject
  org: testorg

I have updated the PR description, thanks!

admin:
  endpoint: dns:///localhost:30080
  insecure: True
logger:
  show-source: true
  level: 0

image:
  builder: local

task:
  domain: development
  project: testproject
  org: testorg

popojk · 2026-03-03T12:24:57Z

Got this error when running make build-sandbox
Downloading docker-registry from repo https://twuni.github.io/docker-registry.helm
Downloading kubernetes-dashboard from repo https://kubernetes-retired.github.io/dashboard/
Downloading minio from repo https://charts.bitnami.com/bitnami
Downloading postgresql from repo https://charts.bitnami.com/bitnami
Deleting outdated charts
mkdir -p manifests
kustomize build \
                --enable-helm \
                --load-restrictor=LoadRestrictionsNone \
                kustomize/complete > manifests/complete.yaml
Error: namespace transformation produces ID conflict: [{"apiVersion":"v1","kind":"Secret","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Secret","internal.config.kubernetes.io/previousNames":"kubernetes-dashboard-csrf","internal.config.kubernetes.io/previousNamespaces":"flyte"},"name":"kubernetes-dashboard-csrf","namespace":"flyte"}} {"apiVersion":"v1","kind":"Secret","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Secret","internal.config.kubernetes.io/previousNames":"kubernetes-dashboard-csrf","internal.config.kubernetes.io/previousNamespaces":"default"},"labels":{"app.kubernetes.io/instance":"flyte-sandbox","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/name":"kubernetes-dashboard","app.kubernetes.io/version":"2.7.0","helm.sh/chart":"kubernetes-dashboard-6.0.0"},"name":"kubernetes-dashboard-csrf","namespace":"flyte"},"type":"Opaque"}]
make[1]: *** [manifests] Error 1
make: *** [build-sandbox] Error 2
I think it's because we enable kubernetes-dashboard here

flyte/charts/flyte-sandbox/values.yaml

Lines 90 to 91 in 784cd7c

kubernetes-dashboard:

enabled: true

And this will create the secret automathically:

flyte/docker/sandbox-bundled/manifests/dev.yaml

Lines 812 to 822 in 784cd7c

apiVersion: v1

kind: Secret

metadata:

labels:

app.kubernetes.io/instance: flyte-sandbox

app.kubernetes.io/managed-by: Helm

app.kubernetes.io/name: kubernetes-dashboard

app.kubernetes.io/version: 2.7.0

helm.sh/chart: kubernetes-dashboard-6.0.0

name: kubernetes-dashboard-csrf

type: Opaque

Then we defined secret with same name in:

flyte/docker/sandbox-bundled/kustomize/dashboard-rbac.yaml

Lines 1 to 5 in 784cd7c

apiVersion: v1

kind: Secret

metadata:

name: kubernetes-dashboard-csrf

namespace: flyte

this cause the conflict

Strange it runs fine in my local machine. I just changed the way to set k8s dashboard secret, can you help me to try again?

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima · 2026-03-04T00:27:28Z

Makefile

+.PHONY: run-sandbox
+run-sandbox: ## Start the flyte sandbox without rebuilding the image
+	$(MAKE) -C docker/sandbox-bundled start
+


Could we add a stop-sandbox command?

fixed in 7ff112c

machichima · 2026-03-04T00:29:10Z

Makefile

+.PHONY: run-sandbox
+run-sandbox: ## Start the flyte sandbox without rebuilding the image
+	$(MAKE) -C docker/sandbox-bundled start
+


btw I think it would be better to name the command as sandbox-..., so that when we type sandbox and press tab, we can see available commands. For example:

fixed in 7ff112c

machichima · 2026-03-04T00:40:40Z

Strange it runs fine in my local machine. I just changed the way to set k8s dashboard secret, can you help me to try again?

Still get error:

kustomize build \
                --enable-helm \
                --load-restrictor=LoadRestrictionsNone \
                kustomize/complete > manifests/complete.yaml
Error: namespace transformation produces ID conflict: [{"apiVersion":"v1","kind":"Service","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Service","internal.config.kubernetes.io/previousNames":"flyte-sandbox-kubernetes-dashboard","internal.config.kubernetes.io/previousNamespaces":"flyte"},"name":"flyte-sandbox-kubernetes-dashboard","namespace":"flyte"},"spec":{"externalName":"flyte-sandbox-kubernetes-dashboard.default.svc.cluster.local","type":"ExternalName"}} {"apiVersion":"v1","kind":"Service","metadata":{"annotations":{"internal.config.kubernetes.io/previousKinds":"Service","internal.config.kubernetes.io/previousNames":"flyte-sandbox-kubernetes-dashboard","internal.config.kubernetes.io/previousNamespaces":"default"},"labels":{"app.kubernetes.io/component":"kubernetes-dashboard","app.kubernetes.io/instance":"flyte-sandbox","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/name":"kubernetes-dashboard","app.kubernetes.io/version":"2.7.0","helm.sh/chart":"kubernetes-dashboard-6.0.0","kubernetes.io/cluster-service":"true"},"name":"flyte-sandbox-kubernetes-dashboard","namespace":"flyte"},"spec":{"ports":[{"name":"http","port":80,"targetPort":"http"}],"selector":{"app.kubernetes.io/component":"kubernetes-dashboard","app.kubernetes.io/instance":"flyte-sandbox","app.kubernetes.io/name":"kubernetes-dashboard"},"type":"ClusterIP"}}]
make[1]: *** [manifests] Error 1
make: *** [build-sandbox] Error 2

I think it might because we are using the different version? Below is the version I used:

# kustomize version
❯ kustomize version
v5.7.1

# helm version
❯ helm version --short
v3.18.6+gb76a950

machichima · 2026-03-04T01:13:35Z

app/k8s.go

+
 func buildRESTConfig(ctx context.Context, kubeconfig string) (*rest.Config, error) {
 	if kubeconfig != "" {
+		kubeconfig = expandPath(kubeconfig)


While this kubeconfig is from the config file, I think it would be better to also add normalize into the config layer, if there's other places that get the kubeconfig, we can also give the normalized path.

We can add util function under flytestdlib/config, and under the GetConfig() for each component, we can do something like so:

func GetConfig() *Config { raw := configSection.GetConfig().(*Config) cfg := *raw cfg.Kubernetes.KubeConfig = config.NormalizeFilePath(cfg.Kubernetes.KubeConfig) return &cfg }

So that we can ensure that the kubeconfig get from the Config struct is always normalized

fixed in e84accb

machichima · 2026-03-04T01:16:28Z

Just a note for follow-up, flyte/executor/cmd/main.go is using GetConfigOrDie while all others use app.InitKubernetesClient, we should make them consistent (all use app.InitKubernetesClient).

flyte/executor/cmd/main.go

Line 44 in b58bbd3

k8sConfig := ctrl.GetConfigOrDie()

machichima · 2026-03-04T01:17:52Z

btw please do:

git rm --cached gen/rust/Cargo.lock

This is already being ignored in the .gitignore, but some branch still have it. We should ensure we clean this up

machichima · 2026-03-04T02:01:32Z

charts/flyte-binary/README.md

@@ -0,0 +1,175 @@
+# flyte-binary
+
+![Version: v0.1.10](https://img.shields.io/badge/Version-v0.1.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)


should be v0.2.0?

fixed in 186914f

machichima · 2026-03-04T02:29:09Z

charts/flyte-binary/values.yaml

+  tasks:
+    # -- Plugins configuration, [structure](https://pkg.go.dev/github.com/flyteorg/flytepropeller/pkg/controller/nodes/task/config#TaskPluginConfig)
+    task-plugins:
+      # -- [Enabled Plugins](https://pkg.go.dev/github.com/lyft/flyteplugins/go/tasks/config#Config).
+      # Enable sagemaker*, athena if you install the backend plugins
+      enabled-plugins:
+        - container
+        - sidecar
+        - connector-service
+        - echo
+      default-for-task-types:
+        container: container
+        sidecar: sidecar
+        container_array: k8s-array
+        # -- Uncomment to enable task type that uses Flyte Connector
+        # bigquery_query_job_task: connector-service


Do we need those? I think now we register the plugin through blank import (although we only do blank import for flyteplugins/go/tasks/plugins/k8s/pod now), but I think this is not used anywhere in v2?

I leave it for now because we might need it in the future I think? e.g. default-for-task-types is crucial when we have multiple plugins for 1 task type and we need to assign the plugin in runtime

machichima · 2026-03-04T02:31:53Z

charts/flyte-binary/templates/configmap.yaml

+        logs:
+          config: {{- include "flyte-binary.configuration.logging.plugins" . | nindent 12 }}
+      {{- if .Values.flyteconnector.enabled }}
+      connector-service:


Just a note. Right now we do not call RegisterConnectorPlugin so that this config does not really work. And is there connector in V2? @pingsutw

We don't have default connector in sandbox in v2, so maybe we don't need this. fixed in ab1ff1e

machichima · 2026-03-04T03:00:28Z

charts/flyte-binary/templates/configmap.yaml

+  002-database.yaml: |
+    {{- with .Values.configuration.database }}
+    database:
+      postgres:


we currently have two options, postgres and sqlite, do we want to include the sqlite config here?

SG. Fixed in 56e61cc

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima · 2026-03-04T09:15:37Z

charts/flyte-binary/templates/admin-auth-secret.yaml

I think this file and charts/flyte-binary/templates/auth-client-secret.yaml are not used anywhere now?

I just leave it because we might need to implement auth feature in the future

machichima · 2026-03-04T09:42:40Z

I test with helm template test and the following case will fail:

❯ helm template test charts/flyte-binary --set ingress.create=true
Error: template: flyte-binary/templates/ingress/grpc.yaml:2:15: executing "flyte-binary/templates/ingress/grpc.yaml" at <include "flyte-binary.ingress.grpcPaths" .>: error calling include: template: no template "flyte-binary.ingress.grpcPaths" associated with template "gotpl"

Use --debug flag to render out invalid YAML

❯ helm template test charts/flyte-binary --set ingress.separateGrpcIngress=false
Error: template: flyte-binary/templates/service/http.yaml:51:15: executing "flyte-binary/templates/service/http.yaml" at <include "flyte-binary.service.grpc.port" .>: error calling include: template: no template "flyte-binary.service.grpc.port" associated with template "gotpl"

Use --debug flag to render out invalid YAML

This is for auth, and we can leave for the follow-up when we are adding auth

❯ helm template test charts/flyte-binary --set configuration.auth.enabled=true
Error: template: flyte-binary/templates/auth-client-secret.yaml:5:11: executing "flyte-binary/templates/auth-client-secret.yaml" at <include "flyte-binary.configuration.auth.clientSecretName" .>: error calling include: template: no template "flyte-binary.configuration.auth.clientSecretName" associated with template "gotpl"

Use --debug flag to render out invalid YAML

machichima · 2026-03-04T09:54:30Z

charts/flyte-binary/templates/service/http.yaml

+    {{- if .Values.commonAnnotations }}
+    {{- tpl ( .Values.commonAnnotations | toYaml ) . | nindent 4 }}
+    {{- end }}
+    {{- if .Values.service.annotations }}


We expect service.annotations from Values.yaml, but it's missing in values.yaml. We should either remove it or add the service.annotations under values.yaml

flyte/charts/flyte-binary/values.yaml

Line 311 in 361af15

service:

fixed in 4eda970

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima · 2026-03-06T09:29:15Z

Got errors when running go test under docker/sandbox-bundled/bootstrap/internal/transform/plugins/config/

~/w/op/flyte-v2/dock/sandbox-bundled/bootstrap/internal/transform/plugins/config add_flyte_binary_build *22 !2 ?1
❯ go test
# github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config [github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config.test]
./loader_test.go:18:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:115:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:125:18: c.clusterResourceTemplates undefined (type *Loader has no field or method clusterResourceTemplates)
./loader_test.go:145:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:155:18: c.clusterResourceTemplates undefined (type *Loader has no field or method clusterResourceTemplates)
FAIL    github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config [build failed]

machichima · 2026-03-06T09:16:33Z

docker/sandbox-bundled/Makefile

+			--env FLYTE_DEV=$(FLYTE_DEV) \
+			--env K3S_KUBECONFIG_OUTPUT=/.kube/kubeconfig \
+			--volume $(PWD)/.kube:/.kube \
+			--volume $(HOME)/.flyte/sandbox:/var/lib/flyte/config \


We have .flyte/sandbox here and .flyte/sandboxv2 below, should we just pick one?

We should only mount to .flyte/sandboxv2, fixed

machichima · 2026-03-06T09:27:17Z

docker/sandbox-bundled/Makefile

+	. .venv/bin/activate && pip install flytekit
+
+.PHONY: test
+test: export FLYTECTL_CONFIG := test/config.yaml


I think there's no test/ directly under sandbox-bundle?

deleted in cdf1207

machichima · 2026-03-06T09:32:53Z

Please do git rm --cached gen/rust/Cargo.lock

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk · 2026-03-09T01:32:30Z

Got errors when running go test under docker/sandbox-bundled/bootstrap/internal/transform/plugins/config/

~/w/op/flyte-v2/dock/sandbox-bundled/bootstrap/internal/transform/plugins/config add_flyte_binary_build *22 !2 ?1
❯ go test
# github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config [github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config.test]
./loader_test.go:18:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:115:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:125:18: c.clusterResourceTemplates undefined (type *Loader has no field or method clusterResourceTemplates)
./loader_test.go:145:3: unknown field ClusterResourceTemplatesConfigMapName in struct literal of type LoaderOpts
./loader_test.go:155:18: c.clusterResourceTemplates undefined (type *Loader has no field or method clusterResourceTemplates)
FAIL    github.com/flyteorg/flyte/docker/sandbox-bundled/bootstrap/internal/transform/plugins/config [build failed]

Fixed in 8d3f05a

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk · 2026-03-09T02:14:35Z

.github/workflows/check-generate.yml

              cd gen/python && uv sync --all-groups --frozen && cd ../.. &&
              make gen-local &&
-              git diff --exit-code || (echo 'Generated files are out of date. Run \`make gen\` and commit changes.' && exit 1) &&
+              git diff --exit-code -- ':!gen/rust/Cargo.lock' || (echo 'Generated files are out of date. Run \`make gen\` and commit changes.' && exit 1) &&


We need to add this otherwise the gen diff CI test is gonna fail

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima · 2026-03-09T03:31:09Z

Overall LGTM! Few last things:

Did we do export KUBECONFIG=$KUBECONFIG:~/.flyte/sandboxv2/kubeconfig when doing make sandbox-run? I think I still need to do it explicitly
Please update the PR description with new make sandbox-XXX command.
Right now the context and cluster name are "default". Could we change the name to "flytev2-sandbox" or something else?

Can be in follow-up PR

Could you add a doc to show how to start the sandbox somewhere?
I think we do not need to run make build-sandbox if we want to run in dev mode? We may need to document this also
Could you also document the username and password for minio? I think it's minio and miniostorage?

machichima · 2026-03-09T03:34:34Z

After running make sandbox-build, the manifests are updated. I think we shouldn't update them every time we build the sandbox?

popojk · 2026-03-09T07:29:31Z

After running make sandbox-build, the manifests are updated. I think we shouldn't update them every time we build the sandbox?

Maybe we should keep it? We only build the sandbox image every time we have a new version of docker image to release. We can automatically make sure the manifests are up to date with this config.

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk · 2026-03-09T07:54:33Z

3. Right now the context and cluster name are "default". Could we change the name to "flytev2-sandbox"

The make file handle export in sub-process, which will not be effective in current terminal context. So seems like we need to execute the exclude command mannually.
Fixed
Make sense, fixed in fbc6cf9

4-6 will be done in follow up issues

machichima

Overall LGTM! Just note that after I did sandbox-stop and sandbox-run, I'll get this error

❯ make sandbox-stop
Makefile:30: warning: overriding commands for target `build'
go.Makefile:75: warning: ignoring old commands for target `build'
Makefile:76: warning: overriding commands for target `help'
go.Makefile:25: warning: ignoring old commands for target `help'
/Library/Developer/CommandLineTools/usr/bin/make -C docker/sandbox-bundled stop
docker stop flyte-sandbox
flyte-sandbox

❯ make sandbox-run
Makefile:30: warning: overriding commands for target `build'
go.Makefile:75: warning: ignoring old commands for target `build'
Makefile:76: warning: overriding commands for target `help'
go.Makefile:25: warning: ignoring old commands for target `help'
/Library/Developer/CommandLineTools/usr/bin/make -C docker/sandbox-bundled start
[ -n "flyte-sandbox" ] || \
                docker volume create flyte-sandbox
docker: Error response from daemon: Conflict. The container name "/flyte-sandbox" is already in use by container "e8b2e7ee4aac95b852516f0bfdb052f0b7d5a7e8630965e6f45784137241c7b0". You have to remove (or rename) that container to be able to reuse that name.

Run 'docker run --help' for more information
make[1]: *** [start] Error 125
make: *** [sandbox-run] Error 2

I'll need to manually remove the old container with

docker rm -f flyte-sandbox

popojk · 2026-03-10T00:37:53Z

Overall LGTM! Just note that after I did sandbox-stop and sandbox-run, I'll get this error

❯ make sandbox-stop
Makefile:30: warning: overriding commands for target `build'
go.Makefile:75: warning: ignoring old commands for target `build'
Makefile:76: warning: overriding commands for target `help'
go.Makefile:25: warning: ignoring old commands for target `help'
/Library/Developer/CommandLineTools/usr/bin/make -C docker/sandbox-bundled stop
docker stop flyte-sandbox
flyte-sandbox

❯ make sandbox-run
Makefile:30: warning: overriding commands for target `build'
go.Makefile:75: warning: ignoring old commands for target `build'
Makefile:76: warning: overriding commands for target `help'
go.Makefile:25: warning: ignoring old commands for target `help'
/Library/Developer/CommandLineTools/usr/bin/make -C docker/sandbox-bundled start
[ -n "flyte-sandbox" ] || \
                docker volume create flyte-sandbox
docker: Error response from daemon: Conflict. The container name "/flyte-sandbox" is already in use by container "e8b2e7ee4aac95b852516f0bfdb052f0b7d5a7e8630965e6f45784137241c7b0". You have to remove (or rename) that container to be able to reuse that name.

Run 'docker run --help' for more information
make[1]: *** [start] Error 125
make: *** [sandbox-run] Error 2

I'll need to manually remove the old container with

docker rm -f flyte-sandbox

Hey I tested it locally multiple times but cannot reproduce the error. I'll merge first and get back to this issue in the future.

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

* add helm chart Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add docker folder for running k3s cluster Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete queue state service add actions service Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete queue state service add actions service Signed-off-by: Alex Wu <c.alexwu@gmail.com> * patch k8s secret config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix unimplement rpc issue Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix k8s dashboard conflict issue Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add normalize path function to std lib Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add sandbox-stop command and fix sandbox command name Signed-off-by: Alex Wu <c.alexwu@gmail.com> * remove cargo file in gen folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix doc flyte version Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete connector config in configmap Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add sqlite config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete service annotation config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix ingress config Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regen manifests Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix some docker script error Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regenerate manifests Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix dicker image name Signed-off-by: Alex Wu <c.alexwu@gmail.com> * add kube folder to gitignore Signed-off-by: Alex Wu <c.alexwu@gmail.com> * remove test make script under sandbox bundle folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix test cases Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete cargo.lock Signed-off-by: Alex Wu <c.alexwu@gmail.com> * regenerate proto Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix gen diff check rule Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix gen check rule to exclude Cargo Signed-off-by: Alex Wu <c.alexwu@gmail.com> * delete complete-connector folder Signed-off-by: Alex Wu <c.alexwu@gmail.com> * fix sandbox cluster name Signed-off-by: Alex Wu <c.alexwu@gmail.com> --------- Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk added 3 commits February 27, 2026 22:14

add helm chart

1289eff

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

add docker folder for running k3s cluster

49c8a93

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

resolve conflict

d031b73

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

github-actions bot mentioned this pull request Feb 28, 2026

Flyte 2 WIP #6583

Draft

3 tasks

pingsutw reviewed Mar 2, 2026

View reviewed changes

popojk added 2 commits March 3, 2026 10:41

delete queue state service add actions service

8a9c1f2

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

delete queue state service add actions service

784cd7c

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk requested a review from pingsutw March 3, 2026 02:44

popojk changed the title ~~Add flyte binary build~~ [V2]Sandbox for flyte v2 Mar 3, 2026

patch k8s secret config

b58bbd3

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima reviewed Mar 4, 2026

View reviewed changes

fix unimplement rpc issue

361af15

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima reviewed Mar 4, 2026

View reviewed changes

fix k8s dashboard conflict issue

3b29479

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima reviewed Mar 6, 2026

View reviewed changes

popojk added 5 commits March 9, 2026 08:10

add kube folder to gitignore

8afcda7

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

remove test make script under sandbox bundle folder

cdf1207

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

fix test cases

8d3f05a

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

delete cargo.lock

c637f21

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

rebase

75cc50f

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk added 3 commits March 9, 2026 09:42

regenerate proto

2dc8bfe

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

fix gen diff check rule

439080e

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

fix gen check rule to exclude Cargo

29a4776

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk commented Mar 9, 2026

View reviewed changes

delete complete-connector folder

2d9411e

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

fix sandbox cluster name

fbc6cf9

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

machichima approved these changes Mar 9, 2026

View reviewed changes

pingsutw approved these changes Mar 9, 2026

View reviewed changes

pingsutw added the flyte2 label Mar 9, 2026

pingsutw assigned popojk Mar 10, 2026

rebase

d241f0a

Signed-off-by: Alex Wu <c.alexwu@gmail.com>

popojk merged commit 5a3e0e6 into v2 Mar 10, 2026
5 checks passed

popojk deleted the add_flyte_binary_build branch March 10, 2026 00:46

pingsutw modified the milestone: V2 GA Mar 10, 2026

		@@ -0,0 +1,175 @@
		# flyte-binary

		![Version: v0.1.10](https://img.shields.io/badge/Version-v0.1.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)

Conversation

popojk commented Mar 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pingsutw commented Mar 2, 2026

Uh oh!

popojk commented Mar 3, 2026

Uh oh!

machichima commented Mar 3, 2026

Uh oh!

machichima commented Mar 3, 2026

Uh oh!

popojk commented Mar 3, 2026

Uh oh!

popojk commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

popojk Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machichima commented Mar 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machichima commented Mar 4, 2026

Uh oh!

machichima commented Mar 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machichima Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machichima commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machichima commented Mar 6, 2026

popojk commented Mar 2, 2026 •

edited by github-actions bot

Loading

popojk Mar 5, 2026 •

edited

Loading

machichima Mar 4, 2026 •

edited

Loading

machichima commented Mar 4, 2026 •

edited

Loading

popojk Mar 9, 2026 •

edited

Loading

machichima commented Mar 9, 2026 •

edited

Loading