Add include_system_secrets to secrets apis#7007
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pmahindrakar-oss
approved these changes
Mar 10, 2026
pingsutw
approved these changes
Mar 10, 2026
katrogan
deleted the
katrina/eng26-278-dont-allow-deletion-of-system-provisioned-api-keys
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Prevents end users from manipulating secrets required for platform functionality
What changes were proposed in this pull request?
Adds proto changes to exclude system generated secrets by default
How was this patch tested?
Tested on a union-internal staging environment
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main