[Sandbox][RunService]Switch database from sqlite to postgresql#7018
Merged
[Sandbox][RunService]Switch database from sqlite to postgresql#7018
Conversation
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
popojk
changed the title
popojk
commented
Mar 12, 2026
flytestdlib/database/postgres.go
Outdated
| // GetPostgresDSN produces the DSN (data source name) for opening a postgres db connection. | ||
| func GetPostgresDSN(ctx context.Context, pgConfig PostgresConfig) string { | ||
| return getPostgresDsn(ctx, pgConfig) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Make this function public so that the Run service repo layer will not need to double implement this string construction logic.
Member
There was a problem hiding this comment.
Could we make the function at line 51 public instead?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
pingsutw
approved these changes
Mar 12, 2026
flytestdlib/database/postgres.go
Outdated
| // GetPostgresDSN produces the DSN (data source name) for opening a postgres db connection. | ||
| func GetPostgresDSN(ctx context.Context, pgConfig PostgresConfig) string { | ||
| return getPostgresDsn(ctx, pgConfig) | ||
| } |
Member
There was a problem hiding this comment.
Could we make the function at line 51 public instead?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
pingsutw
approved these changes
Mar 13, 2026
afbrock
pushed a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7002
Why are the changes needed?
We should switch the database from sqlite to PostgreSQL so that we can use pg notify in RunService
What changes were proposed in this pull request?
How was this patch tested?
make sandbox_buildand run sandbox withmake sandbox_runpython examples/basics/devbox_one.pyLabels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main