Conversation
When a task template has log_links in its metadata, pass them through to the log plugin system as TemplateLogPlugin entries. Also adds an IconUri field to TemplateLogPlugin. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
approved these changes
Mar 13, 2026
afbrock
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
When a task template has
log_linksin its metadata, those links should be passed through to the log plugin system so they appear in the UI. This enables task authors to attach custom log links (e.g., to external monitoring systems) directly to task templates.What changes were proposed in this pull request?
taskTemplate *core.TaskTemplateas a second parameter toInitializeLogPluginslog_linksin its metadata, prepend them asTemplateLogPluginentriesIconUrifield toTemplateLogPluginstructInitializeLogPluginsacross dask, kfoperators, pod, ray, spark, and connector plugins to pass the task template (ornilwhere unavailable)How was this patch tested?
go test ./flyteplugins/...go vet ./flyteplugins/...passes cleanlygo build ./flyteplugins/...compiles successfullyLabels
Check all the applicable boxes
🤖 Generated with Claude Code
main