Skip to content

feat(runs): wire AbortRun and AbortAction through to ActionsService #7031

Merged
AdilFayyaz merged 3 commits intov2from
adil/migrate-run-service-abort
Mar 14, 2026
Merged

feat(runs): wire AbortRun and AbortAction through to ActionsService #7031
AdilFayyaz merged 3 commits intov2from
adil/migrate-run-service-abort

Conversation

@AdilFayyaz
Copy link

@AdilFayyaz AdilFayyaz commented Mar 14, 2026

Why are the changes needed?

AbortRun and AbortAction previously only updated the run phase in the database, leaving the TaskAction CR and its pod still running in Kubernetes. This connects the abort path to ActionsService.Abort so execution is actually stopped.

What changes were proposed in this pull request?

  • AbortRun now calls actionsClient.Abort() with the root action ID after the DB update, triggering K8s-side CR deletion and cascade to all descendants
  • AbortAction similarly calls actionsClient.Abort() for the specific action after the DB update

How was this patch tested?

  • Start the manager (make -C manager run) against a local sandbox
  • Submit a run via uv run flyte run ... and confirm pods appear in [namespace]
  • Run kubectl -n [namespace] get taskactions to confirm the CR exists
  • Abort with uv run flyte abort run
  • Verify TaskAction CR is deleted: kubectl -n [namespace] get taskactions
  • Verify run phase is ABORTED: uv run flyte get run
  • Verify manager logs show "Aborted run..." and "Deleted TaskAction ... (descendants will be cascade deleted by K8s)"
  • Added tests to run_service_test.go

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
@AdilFayyaz AdilFayyaz self-assigned this Mar 14, 2026
@AdilFayyaz AdilFayyaz added added Merged changes that add new functionality flyte2 labels Mar 14, 2026
@github-actions github-actions bot mentioned this pull request Mar 13, 2026
3 tasks
@AdilFayyaz AdilFayyaz requested review from pingsutw March 14, 2026 01:01
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
@AdilFayyaz AdilFayyaz merged commit 1ef5450 into v2 Mar 14, 2026
14 checks passed
@AdilFayyaz AdilFayyaz deleted the adil/migrate-run-service-abort branch March 14, 2026 01:23
afbrock pushed a commit that referenced this pull request Mar 18, 2026
…7031)

* abort - add

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

* update

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

* update test

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>

---------

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added Merged changes that add new functionality flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants