Add node_name to the container selector#7036
Merged
jeevb merged 1 commit intoflyteorg:v2from Mar 16, 2026
Merged
Conversation
To facilitate getting logs just for a single node, add an optional field to the ContainerSelector message. Signed-off-by: Eugene Yakubovich <eyakubovich@gmail.com>
eyakubovich
force-pushed
the
ey/log-svc-node
branch
from
8a87904 to
8c0d95c
Compare
jeevb
approved these changes
Mar 16, 2026
|
Congrats on merging your first pull request! 🎉 |
afbrock
pushed a commit
that referenced
this pull request
Mar 18, 2026
To facilitate getting logs just for a single node, add an optional field to the ContainerSelector message. Signed-off-by: Eugene Yakubovich <eyakubovich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To facilitate getting logs just for a single node, add an optional field to the ContainerSelector message.
How was this patch tested?
This patch only adds a field to the protobuf file, no functionality was implemented.
Check all the applicable boxes