[V2][Bug] Fix sandbox dev mode dir permission error#7061
Merged
Conversation
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
popojk
changed the title
popojk
commented
Mar 20, 2026
popojk
commented
Mar 20, 2026
popojk
commented
Mar 20, 2026
machichima
reviewed
Mar 20, 2026
executor/pkg/webhook/init_cert.go
Outdated
|
|
||
| logger.Infof(ctx, "Issuing certs") | ||
| certs, err := createCerts(cfg.ServiceName, podNamespace) | ||
| var extraDNSNames []string |
Member
There was a problem hiding this comment.
Are we planning to add more extra DNS name in the future? If not, maybe we can just using "string" type?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
pingsutw
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
We should support webhook tls certificate under sandbox dev mode
Why are the changes needed?
Fix webhook tls certificate dir permission denied error under sandbox dev mode
What changes were proposed in this pull request?
How was this patch tested?
The sandbox can successfully up and run in dev mode
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main