Conversation
The org field is not needed in OSS Flyte. This removes it from all Go code across database models, repository queries, CRD types, services, executor, actions client, and plugins. Proto definitions are left unchanged; the org field is simply no longer populated or read. Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orgfield from all database models (Action, ActionEvent, TaskKey, TaskName), CRD types (TaskActionSpec), repository queries, services, executor, actions client, and pluginsorgfield is not needed in OSS Flyte — proto definitions are left unchanged but the field is no longer populated or readChanges by layer
Orgfrom Action, ActionEvent, TaskKey, TaskName, TaskGroupNotificationPayload structsListRootActionssignatureOrgfrom TaskActionSpec, CRD YAML schema, controller validation, plugin metadata env varsflyte.org/orgK8s label, org from identifiersTest plan
go build ./...passesgo vetpasses on all affected packagesruns/,executor/,actions/,flyteplugins/,dataproxy/,cache_service/)main