Merged
Conversation
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
popojk
commented
Apr 6, 2026
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.embedded-postgres-go | ||
| key: embedded-postgres-v16 |
Contributor
Author
There was a problem hiding this comment.
Cache embedded-postgres so we don't need to download it while running CI everytime
popojk
commented
Apr 6, 2026
|
|
||
| var testDB *gorm.DB | ||
|
|
||
| func TestMain(m *testing.M) { |
Contributor
Author
There was a problem hiding this comment.
We add the TestMain here so go test command will execute it before running tests
popojk
commented
Apr 6, 2026
| @@ -0,0 +1,60 @@ | |||
| package database | |||
Contributor
Author
There was a problem hiding this comment.
We originally use SQLITE as the db for certain tests, but now we no longer have it. Thus, now we use embedded postgresql as the db for tests, and this file contains the helper functions for doing so.
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
approved these changes
Apr 6, 2026
Signed-off-by: Kevin Su <pingsutw@apache.org>
Remove duplicate import of flyteidl2/common that was introduced during conflict resolution, causing build failures. Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
n/a
Why are the changes needed?
We will not need sqlite anymore
What changes were proposed in this pull request?
Remove sqlite from sandbox
How was this patch tested?
Lyft off!
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main