[V2] Fix pod owner reference to enable watch-triggered reconciles#7167
Merged
[V2] Fix pod owner reference to enable watch-triggered reconciles#7167
Conversation
The pod owner reference was missing Controller: true, which meant
controller-runtime's Owns(&corev1.Pod{}) did not recognize pods as
controller-owned. Pod status changes (Pending → Running → Succeeded)
never triggered reconciles, causing intermediate phases like RUNNING
to be missed in action events.
Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Controller: trueon the pod owner reference so that controller-runtime'sOwns(&corev1.Pod{})recognizes pods as controller-ownedflyte/executor/pkg/controller/taskaction_controller.go
Line 53 in 9b5cffb
Before:
After:
Test plan
main