[V2] Fix dataproxy proto: add code bundle artifact type and fix field numbering#7220
Merged
[V2] Fix dataproxy proto: add code bundle artifact type and fix field numbering#7220
Conversation
… numbering Add ARTIFACT_TYPE_CODE_BUNDLE to support code bundle downloads and fix CreateDownloadLinkResponse field numbering to use field 1 instead of reserved field 3. Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
katrogan
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The dataproxy proto needs two fixes:
ARTIFACT_TYPE_CODE_BUNDLEenum value is needed to support downloading code bundles (tarballs) generated for actions.CreateDownloadLinkResponsefield numbering used a reserved field 3 with fields 1 and 2 marked as reserved, which is unnecessary. The field is renumbered to 1 for a cleaner proto definition.What changes were proposed in this pull request?
ARTIFACT_TYPE_CODE_BUNDLE = 2to theArtifactTypeenum indataproxy_service.protoreserved 1, 2declaration fromCreateDownloadLinkResponseand changedpre_signed_urlsfrom field number 3 to field number 1How was this patch tested?
Proto definition change only — verified the proto file is valid.
main