Open
Conversation
Add pod_name field to TailLogsRequest proto to allow specifying which pod to tail logs from. If not provided, the service will attempt to find the primary pod, else assume the first pod. Signed-off-by: Kevin Su <pingsutw@apache.org>
katrogan
reviewed
Apr 16, 2026
| uint32 attempt = 2 [(buf.validate.field).uint32.gt = 0]; | ||
|
|
||
| // The pod name to tail logs from. If not provided, attempt to find the primary pod, else assume the first pod. | ||
| string pod_name = 3 [(buf.validate.field).string.min_len = 1]; |
Contributor
There was a problem hiding this comment.
this service is deprecated, I just moved this over to dataproxy :) can we update?
#7194
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
katrogan
reviewed
Apr 17, 2026
| uint32 attempt = 2 [(buf.validate.field).uint32.gt = 0]; | ||
|
|
||
| // The pod name to tail logs from. If not provided, attempt to find the primary pod, else assume the first pod. | ||
| string pod_name = 3; |
Contributor
There was a problem hiding this comment.
can we remove this? since run logs service is deprecated we shouldn't be updating it anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Currently, `TailLogsRequest` only accepts an action execution ID and attempt number, which means the service has to guess which pod to tail logs from. Adding a `pod_name` field allows callers to explicitly specify the target pod, which is useful when an action has multiple pods.
What changes were proposed in this pull request?
Add a `pod_name` field (field number 3) to `TailLogsRequest` in
run_logs_service.proto. If not provided, the service will attempt to find the primary pod, else assume the first pod.Regenerated all language bindings (Go, Python, Rust, TypeScript).
How was this patch tested?
Proto compilation and code generation verified.
Labels
Check all the applicable boxes
main