fix: resolve buf lint violations and fix timed macro exit code#7230
Merged
fix: resolve buf lint violations and fix timed macro exit code#7230
Conversation
SVilgelm
changed the title
SVilgelm
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the root Makefile’s timed macro so it reports elapsed time while correctly propagating the wrapped command’s exit status, ensuring CI/automation targets fail when the underlying step fails.
Changes:
- Capture the wrapped command’s exit code (
rc=$$?) immediately after execution. - Print timing output and then
exit $$rcso Make observes the correct failure/success status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The timed macro previously lost the exit code of the wrapped command due to chaining with semicolons — make always saw the exit code from the final echo statement (0). Now the macro captures the command's exit code in a variable, prints the timing, then exits with the original code, ensuring CI targets like buf-lint properly fail when violations are detected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
- Remove unused import of google/api/annotations.proto from cluster/service.proto - Remove unused import of flyteidl2/task/common.proto from queue_service.proto - Fix package mismatch in settings protos: change package from flyteidl2.org to flyteidl2.settings and update all field option references accordingly - Remove unused buf dependency buf.build/grpc-ecosystem/grpc-gateway - Regenerate all generated files (Go, Python, Rust, TypeScript) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
SVilgelm
force-pushed
the
svilgelm/fix-makefile-timed-exit-code
branch
from
a8d1f74 to
4284524
Compare
kumare3
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timedMakefile macro: The macro previously swallowed the exit code of wrapped commands (e.g.buf lint) because semicolons chained commands — make always saw exit 0 from the finalecho. Now captures the exit code, prints timing, then exits with the original code.google/api/annotations.proto,flyteidl2/task/common.proto)flyteidl2.org→flyteidl2.settingsto match directory structurebuf.build/grpc-ecosystem/grpc-gatewayTest plan
make buf-lintfails when proto files have lint violationsmake buf-lintpasses after fixing all violations🤖 Generated with Claude Code
main