Merged
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
katrogan
approved these changes
Apr 17, 2026
pingsutw
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
SelectClusterpreviously returned a statically configureddataplaneDomain(the dataproxybaseURL) as the cluster endpoint for every caller. That forced all clients to talk to the same hostname regardless of how they actually reached the service — breaking setups where the same deployment is fronted by multiple hostnames (e.g. per-tenant/per-region ingresses, local port-forwards, or internal vs. external URLs).Using the request's
Hostheader lets the server echo back whatever host the client used to reach it, so clients keep talking to the endpoint they already have a working route to.What changes were proposed in this pull request?
SelectClusternow reads theHostheader off the inbound request and returns it asClusterEndpoint.dataplaneDomainfield and constructor argument fromClusterService;NewClusterService()no longer needs the configured base URL.dataproxy/setup.goto call the simplified constructor, plus a minor import ordering cleanup.How was this patch tested?
Manual verification via the dataproxy endpoint —
SelectClusternow returns the host the client used to reach it rather than the configured dataplane domain.Labels
Check all the applicable boxes