fix(dataproxy): GetActionData returns empty inputs for sub-actions#7337
Merged
fix(dataproxy): GetActionData returns empty inputs for sub-actions#7337
Conversation
GetActionData returned empty inputs for sub-actions because the dataproxy unconditionally appended "inputs.pb" to the stored InputsUri. Sub-actions already stored the full path (.../inputs.pb), so the dataproxy ended up reading .../inputs.pb/inputs.pb (404). Root actions worked only because they stored a prefix without the suffix. Normalize on the full file path: store inputs.pb in the root's RunInfo.InputsUri and have the dataproxy read the URI verbatim. Signed-off-by: Kevin Su <pingsutw@apache.org>
🐳 Docker CI Image BuiltThe CI Docker image has been built and pushed for this PR! Image: This image will be automatically used by CI workflows in this PR. To test locally: make gen DOCKER_CI_IMAGE=ghcr.io/flyteorg/flyte/ci:pr-7337 |
ursucarina
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
n/a
Why are the changes needed?
GetActionDataworks for root actions but returns empty inputs for sub-actions. Verified against a live cluster:RunInfo.InputsUri = s3://flyte-data/uploads/.../offloaded-inputs/<hash>(prefix only).RunInfo.InputsUri = s3://flyte-data/.../<sub>/inputs.pb(full path).dataproxy.GetActionDataunconditionally appendedinputs.pbto the stored URI:For root that resolved to the real file; for sub-actions it produced
.../inputs.pb/inputs.pband 404'd silently.What changes were proposed in this pull request?
Normalize on storing the full file path in
RunInfo.InputsUriand let the dataproxy read it verbatim:runs/service/run_service.go:persistRunModelnow storesinputPrefix + "/inputs.pb", matching what sub-actions already store viarecordSingleAction.dataproxy/service/dataproxy_service.go: drop theConstructReference(..., "inputs.pb")and readInputsUridirectly.How was this patch tested?
dataproxy/service/dataproxy_service_test.goandruns/service/run_service_test.goto reflect the new contract.go test ./dataproxy/service/... ./runs/service/...passes.Labels
fixed
Check all the applicable boxes