This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Trim whitespace for password #patch#281
Merged
EngHabu merged 1 commit intoflyteorg:masterfrom Nov 5, 2021
Merged
Conversation
Same as flyteorg/datacatalog#56 Signed-off-by: stephen batifol <stephen.batifol@wolt.com>
stephen37
requested review from
EngHabu,
anandswaminathan,
katrogan,
kumare3 and
wild-endeavor
as code owners
|
Thank you for opening this pull request! 🙌 |
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 57.59% 57.59%
=======================================
Files 143 143
Lines 10550 10550
=======================================
Hits 6076 6076
Misses 3806 3806
Partials 668 668
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EngHabu
approved these changes
Nov 3, 2021
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Same as flyteorg/datacatalog#56 Signed-off-by: stephen batifol <stephen.batifol@wolt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: stephen batifol stephen.batifol@wolt.com
TL;DR
Same as flyteorg/datacatalog#56
Type
Are all requirements met?
Complete description
Use the function TrimSpace that "returns a slice of the string s, with all leading and trailing white space removed, as defined by Unicode."