This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Added connection pooling to DB config and added defaults for the same#358
Merged
Added connection pooling to DB config and added defaults for the same#358
Conversation
pmahindrakar-oss
requested review from
EngHabu,
anandswaminathan,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 58.43% 58.44% +0.01%
==========================================
Files 152 152
Lines 11073 11084 +11
==========================================
+ Hits 6470 6478 +8
- Misses 3903 3906 +3
Partials 700 700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2 tasks
lupasarin
previously approved these changes
Mar 1, 2022
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
pmahindrakar-oss
force-pushed
the
pmahindrakar/1956
branch
2 times, most recently
from
2f5e9c2 to
f798f42
Compare
EngHabu
approved these changes
Mar 2, 2022
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…#358) * Added connection pooling to DB config and added defaults for the same Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * go mod changes for sql lite used for unit tests Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * linter fixes Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * test fix Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * feedback Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * updated the description for the flags Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com
TL;DR
Added connection pooling for the admin DB config.
Conservative defaults have been added based on the RDS limits.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#1956
Follow-up issue
NA