Conversation
The v1.16.17 release failed because a transient PyPI connection error during plugin upload killed the entire deploy job, and re-runs failed because already-uploaded packages return 400. The manual build_image workflow also failed because it passed github.sha as the package version instead of the actual semver. Changes: - Upgrade actions/setup-python from v1 to v5 and pin Python to 3.12 (3.x resolved to unstable Python 3.14) - Add --verbose --skip-existing to all twine upload commands so re-runs skip already-uploaded packages instead of failing - Fix build_image.yml to derive VERSION from branch/tag name instead of github.sha, which is not a valid PyPI version - Use safer shell parameter expansion for GITHUB_REF parsing Signed-off-by: Kevin Su <kevin@union.ai> Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
samhita-alla and
wild-endeavor
as code owners
If triggered from a non-version ref like 'master', error out with a clear message instead of silently using an invalid PyPI version. Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue
N/A - operational fix for release pipeline
Why are the changes needed?
The v1.16.17 release pipeline failed due to multiple issues:
Transient PyPI connection error: The
flytekitplugins_daskupload hung for 4 minutes during plugin publishing, then PyPI dropped the connection (RemoteDisconnected). This killed the entiredeployjob, causing all Docker image builds to be skipped.Re-runs are not idempotent: Re-running the failed workflow fails immediately because
twine uploadreturns400 Bad Requestfor already-uploaded packages.build_image.ymlpassesgithub.shaas VERSION: The manual image build workflow passed the commit SHA as the PyPI version, which is not a valid PEP 440 version string, causinguv pip install flytekit==<sha>to fail.Unstable Python version:
actions/setup-python@v1withpython-version: "3.x"resolved to Python 3.14.3, which is brand new and potentially unstable for building release artifacts.What changes were made?
pythonpublish.ymlactions/setup-pythonfrom v1 to v53.x--verbose --skip-existingtotwine uploadso re-runs skip already-uploaded packages${GITHUB_REF#refs/tags/v}) instead of piping throughsedbuild_image.ymlget-versionjob that extracts the semver from the branch/tag name (stripsvprefix)github.shaas theVERSIONbuild argplugins/Makefile--verbose --skip-existingto bothtwine uploadcommandsHow was this tested?
Reviewed CI logs from the failed v1.16.17 release runs:
Check all the applicable boxes