Add a missing include for the C++ module build - #4868
Merged
Conversation
Contributor
|
Please rebase to fix timezone issues. |
The std.h header uses types such as std::atomic and std::atomic_flag.
For the normal build mode, this header does include all the
headers it needs, such as <atomic>.
However when building the C++ module of {fmt}, the std.h header
omits such includes, and instead expects them to be included
beforehand by fmt.cc - which lacked including <atomic>.
This fixes building the C++ module with libc++ 23, which has removed
a number of unnecessary transitive includes.
mstorsjo
force-pushed
the
missing-include-modules
branch
from
July 29, 2026 18:37
8fe59f0 to
f60cb7b
Compare
Contributor
Author
Ok, done. |
vitaut
approved these changes
Jul 29, 2026
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The std.h header uses types such as std::atomic and std::atomic_flag. For the normal build mode, this header does include all the headers it needs, such as .
However when building the C++ module of {fmt}, the std.h header omits such includes, and instead expects them to be included beforehand by fmt.cc - which lacked including .
This fixes building the C++ module with libc++ 23, which has removed a number of unnecessary transitive includes.