fn user added to runtime image#74
Conversation
| @@ -1 +1,3 @@ | |||
| FROM python:3.7.1-slim-stretch | |||
|
|
|||
| RUN addgroup -g 1000 -S fn && adduser -S -u 1000 -G fn fn | |||
There was a problem hiding this comment.
@denismakogon should we move this image to https://github.com/fnproject/dockers ? fdks should be code only? at least, we're not consistent at the moment, and a few reside in the dockers repo already (python3.6 even)
There was a problem hiding this comment.
additional point is that the dockers repo has a handy script for updating the lang images (would like to add this to ci to automate even, haven't quite gotten time yet)
There was a problem hiding this comment.
the reason for keeping image files here is that dockers repo looks more like a dump of whatever we had from IronFunctions.
I'm not sure that moving files back there is a good idea unless the repo would be cleaned up.
There was a problem hiding this comment.
regarding image files, only fdk-go didn't have its image files in the fdk repo, but the rest keeping their files in place, but not in dockers.
There was a problem hiding this comment.
FDKs should own their images. Dockers repo should probably die.
There was a problem hiding this comment.
sure, not blocking - there's a python image to update in dockers repo, as well, it's unclear which is the preferred place (one is 3.6 and one is 3.7) and this is a fine excuse to find such things and straighten them out
There was a problem hiding this comment.
ah, I see - in that case I say bring the 3.6 image in here - the java FDK builds 8, 11 and SVM images.
There was a problem hiding this comment.
as to rationale, I think FDKs should own their build images, runtime images, init images and maybe a test/hello-world image, as one can't simply use docker/hello-world anymore...
There was a problem hiding this comment.
So, I'm going to merge this PR.
This is quite a wider discussion regarding where image files should live, but it's just out of the scope of this PR.
denismakogon
left a comment
denismakogon
left a comment
There was a problem hiding this comment.
@rikgibson please approve/merge.
4 participants
No description provided.