fnproject · nishalad95 · Mar 29, 2019 · Mar 27, 2019 · rdallman · Mar 27, 2019
diff --git a/images/runtime/3.7.1/Dockerfile b/images/runtime/3.7.1/Dockerfile
@@ -1 +1,3 @@
 FROM python:3.7.1-slim-stretch
+
+RUN addgroup -g 1000 -S fn && adduser -S -u 1000 -G fn fn
Original file line number	Diff line number	Diff line change
		@@ -1 +1,3 @@
		FROM python:3.7.1-slim-stretch

		RUN addgroup -g 1000 -S fn && adduser -S -u 1000 -G fn fn
Copy link Copy Markdown Contributor rdallman Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @denismakogon should we move this image to https://github.com/fnproject/dockers ? fdks should be code only? at least, we're not consistent at the moment, and a few reside in the dockers repo already (python3.6 even) Copy link Copy Markdown Contributor rdallman Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. additional point is that the dockers repo has a handy script for updating the lang images (would like to add this to ci to automate even, haven't quite gotten time yet) Copy link Copy Markdown Member denismakogon Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. the reason for keeping image files here is that dockers repo looks more like a dump of whatever we had from IronFunctions. I'm not sure that moving files back there is a good idea unless the repo would be cleaned up. Copy link Copy Markdown Member denismakogon Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. regarding image files, only fdk-go didn't have its image files in the fdk repo, but the rest keeping their files in place, but not in dockers. Copy link Copy Markdown rikgibson Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. FDKs should own their images. Dockers repo should probably die. Copy link Copy Markdown Contributor rdallman Mar 27, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. sure, not blocking - there's a python image to update in dockers repo, as well, it's unclear which is the preferred place (one is 3.6 and one is 3.7) and this is a fine excuse to find such things and straighten them out Copy link Copy Markdown rikgibson Mar 28, 2019 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. ah, I see - in that case I say bring the 3.6 image in here - the java FDK builds 8, 11 and SVM images. Copy link Copy Markdown rikgibson Mar 28, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. sorry, pay attention rik... Copy link Copy Markdown rikgibson Mar 28, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. as to rationale, I think FDKs should own their build images, runtime images, init images and maybe a test/hello-world image, as one can't simply use docker/hello-world anymore... Copy link Copy Markdown Member denismakogon Mar 29, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. So, I'm going to merge this PR. This is quite a wider discussion regarding where image files should live, but it's just out of the scope of this PR.