Skip to content

fix: adjust param name from hideArchived to showArchived#908

Merged
smarcet merged 1 commit into
masterfrom
fix/show-archived-missing
Apr 30, 2026
Merged

fix: adjust param name from hideArchived to showArchived#908
smarcet merged 1 commit into
masterfrom
fix/show-archived-missing

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented Apr 29, 2026

ref: https://app.clickup.com/t/86b7v230m

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

Bug Fixes

  • Fixed archived items filter to correctly apply when adjusting pagination settings across sponsor and form template pages.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet April 29, 2026 16:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2e2f871-ac2c-4ae3-8e49-6a9b9ef24224

📥 Commits

Reviewing files that changed from the base of the PR and between 32abc59 and 27c0aa2.

📒 Files selected for processing (3)
  • src/pages/sponsors-global/form-templates/form-template-item-list-page.js
  • src/pages/sponsors/sponsor-form-item-list-page/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js

📝 Walkthrough

Walkthrough

This PR corrects a bug across three components where the hideArchived variable was incorrectly used instead of the showArchived checkbox-driven state value when handling pagination "per page" changes, ensuring consistent archived-item filtering behavior throughout the page.

Changes

Cohort / File(s) Summary
Archived-filter parameter correction
src/pages/sponsors-global/form-templates/form-template-item-list-page.js, src/pages/sponsors/sponsor-form-item-list-page/index.js, src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js
Replaced hideArchived with showArchived in per-page change handlers to align pagination reload behavior with the archived-items filter used in sorting and page navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • smarcet

Poem

🐰 A checkbox whispers true or false,
Yet handlers danced with logic flaws,
Now "show" aligns with "hide" no more,
Archived items filter at the core! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly summarizes the main change across all three files: replacing hideArchived parameter references with showArchived for consistent archived-item filtering behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/show-archived-missing

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 3662932 into master Apr 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants