Enforce Authorization header on index-server#327
Merged
Conversation
The index-server handler stored the configured authorization value but never compared it against incoming requests, so --authorization and DESYNC_HTTP_AUTH had no effect. Add the same check used by the chunk handler, using crypto/subtle.ConstantTimeCompare to avoid timing side-channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPIndexHandlerstored the configured authorization value but never checked it against incoming requests, so--authorization/DESYNC_HTTP_AUTHsilently had no effect ondesync index-server.httphandler.go:34), usingcrypto/subtle.ConstantTimeCompareto avoid leaking the configured token through timing.