Use constant-time compare for chunk-server auth header#328
Merged
Conversation
The chunk-server's Authorization header check used a plain string comparison, which leaks information about the configured token through timing. Switch to crypto/subtle.ConstantTimeCompare to match the hardened check on the index-server handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authorizationheader check inhttphandler.goused a plain!=comparison, which leaks information about the configured token through timing.crypto/subtle.ConstantTimeCompareto match the check on the index-server handler (Enforce Authorization header on index-server #327).