Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/_actionlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ jobs:

- name: actionlint
uses: raven-actions/actionlint@v2
# with:
# # overly pedantic quoting requirements
# flags: -ignore SC2046 -ignore SC2086
# do NOT ignore errors at the run level or at the file level; ignore them at the line level only:
# https://github.com/koalaman/shellcheck/wiki/ignore
23 changes: 11 additions & 12 deletions .github/workflows/docker-description.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,17 @@ jobs:
ARTIFACT_ID: ${{ inputs.artifact-id }}
DESCRIPTION: ${{ inputs.repo-description }}
run: |
if [ "$PUBLISH_MODULE_DESCRIPTOR" = "true" ]; then
option_md="--module-descriptor ModuleDescriptor.json"
else
option_md=""
fi
echo "option_md=${option_md}"
python3 folio-tools/github-actions-scripts/generate_dockerhub_description.py \
--loglevel debug \
--repo-url "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}" \
--module-name "$ARTIFACT_ID" \
--description "$DESCRIPTION" \
--output-file dockerhub-description.md "${option_md}"
# Use array for proper quoting: https://github.com/koalaman/shellcheck/wiki/SC2086#exceptions
options=(
--loglevel debug
--repo-url "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}"
--module-name "$ARTIFACT_ID"
--description "$DESCRIPTION"
--output-file dockerhub-description.md
)
[ "$PUBLISH_MODULE_DESCRIPTOR" = "true" ] && options=("${options[@]}" --module-descriptor ModuleDescriptor.json)
echo "options:" "${options[@]}"
python3 folio-tools/github-actions-scripts/generate_dockerhub_description.py "${options[@]}"

- name: Show description output
run: cat dockerhub-description.md
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## IN PROGRESS

* FOLIO-4555 Double-quote variables - in #164
* FOLIO-4555 Double-quote variables - in #164, #166
* (Add more progress summary items here.)

## [1.16.3](https://github.com/folio-org/.github/tree/v1.16.3) (2026-07-14)
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ While developing Workflows run actionlint prior to each commit. It is very helpf
actionlint *.yml
```

It includes "shellcheck". The following invocation skips some well-known shellcheck basic issues (but it is best to fix them before commit):
It includes "shellcheck".

```
SHELLCHECK_OPTS='--exclude=SC2086,SC2046' actionlint *.yml
```
If there is a false positive disable it at the line level. Avoid diabling it at the file or run level because we want linting for future file changes.

For details see [ShellCheck Ignore](https://github.com/koalaman/shellcheck/wiki/ignore).

There is an automated workflow that will run `actionlint` on pull-requests.

Expand Down