MODEMAIL-131 - Change bcc field to array of email addresses #125
MODEMAIL-131 - Change bcc field to array of email addresses #125markusweigelt wants to merge 3 commits into
Conversation
Model bcc as a JSON array of email strings instead of a comma-separated string, so MailServiceImpl.resolveBcc consumes the list directly and hands it to Vert.x setBcc(List) without splitting or re-joining.
Signals the optional bcc array field added to POST /email as a backwards-compatible addition over the released email 1.1 interface.
Replaces collect(Collectors.toList()) with the immutable Stream.toList(), so resolveBcc consistently returns an unmodifiable list.
|
| "description": "Blind carbon copy recipient", | ||
| "type": "string", | ||
| "format": "email" | ||
| } |
There was a problem hiding this comment.
it could be considered as a breaking change, so API version must be increased,
to avoid that - I would suggest to add new field - bccItems and deprecate this one
There was a problem hiding this comment.
@pfilippov-epam Thank you for your review and approval.
The BCC feature was only introduced in mid-June with that PR #124 and has not been included in any release yet. As far as we know, we are currently the only ones using it.
We missed the version bump in the June PR cause adding this field. In our opinion, updating the version is necessary so that we can properly reference it in the modules that depend on this feature.
Please let me know if, with this context, you are okay with merging it?
2 participants
MODEMAIL-131 - Change bcc field to array of email addresses
Purpose
The
bccfield on POST /email was introduced (MODEMAIL-129) as a single comma-separated string. This change reworks it into a proper JSON array of email addresses so callers pass a structured list rather than encoding multiple recipients into one delimited string.Approach
ramls/email_entity.json: redefinebccas an array of email-string items instead of a single stringMailServiceImpl.resolveBcc: consume the list directly and hand it to Vert.xsetBcc(List)- no comma-splitting or re-joining.descriptors/ModuleDescriptor-template.json: bump the providedemailinterface version to1.2to signal the optionalbccarray field cause missing in MODEMAIL-129.SendingEmailTestandMailServiceImplTestto exercise the array-based bcc.