OKAPI-1243: equals should support subclasses of ModuleId, SemVer, …#1442
Merged
julianladisch merged 3 commits intomasterfrom Apr 2, 2026
Merged
OKAPI-1243: equals should support subclasses of ModuleId, SemVer, …#1442julianladisch merged 3 commits intomasterfrom
julianladisch merged 3 commits intomasterfrom
Conversation
…enUserCache.TokenKey https://folio-org.atlassian.net/browse/OKAPI-1243 equals should not use instanceof but getClass() to support subclasses: * https://github.com/SonarSource/sonar-java/blob/8.26.0.42915/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S2162.html * https://wiki.sei.cmu.edu/confluence/spaces/java/pages/88487427/MET08-J.+Preserve+the+equality+contract+when+overriding+the+equals+method Sonar reports this issue: * https://sonarcloud.io/project/issues?rules=java%3AS2162&issueStatuses=FIXED%2COPEN&id=org.folio.okapi%3Aokapi Task: Fix the equals implementation of ModuleId, SemVer, TokenUserCache.TokenKey.
adamdickmeiss
approved these changes
Apr 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/OKAPI-1243
equals should not use instanceof but getClass() to support subclasses:
Sonar reports this issue:
Task: Fix the equals implementation of ModuleId, SemVer, TokenUserCache.TokenKey.