Skip to content

STCLI-187: Update webpack to v5#270

Merged
zburke merged 3 commits into
masterfrom
STCLI-187
Nov 5, 2021
Merged

STCLI-187: Update webpack to v5#270
zburke merged 3 commits into
masterfrom
STCLI-187

Conversation

@mkuklis

@mkuklis mkuklis commented Oct 11, 2021

Copy link
Copy Markdown
Contributor

https://issues.folio.org/browse/STCLI-187

There is a corresponding PR in stripes-webpack folio-org/stripes-webpack#36 which will need to be merged first in order for this one to pass.

@zburke

zburke commented Oct 15, 2021

Copy link
Copy Markdown
Member

@mkuklis, thinking through this again, it feels like webpack should be a direct-dep here but a peer-dep in stripes-webpack. That would force both repos to agree on using the same version. And then it would make sense for this to be a major-version-bump in stripes-webpack (bumping a major version of a peer always means bumping your own major). Otherwise, as-is, webpack is just an interal dep in stripes-webpack and there's no reason to bump the version there at all if we're not changing the external API of that package.

I realize we have discussed the fact that "stripes-cli is probably the wrong conduit for commands that are simply funneled straight through to stripes-webpack", so maybe it's fine to ignore this for now, knowing we want to make other bigger changes later. But when later comes, I think it's something to consider.

@mkuklis

mkuklis commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

@zburke thank you for sharing your thoughts. I agree. Let me test couple more things here.

@mkuklis

mkuklis commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

@zburke I moved webpack to peerDependencies in stripes-webpack. I also had to list it under devDependencies because we need it there to run tests.

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke
zburke merged commit 1eebaf0 into master Nov 5, 2021
@zburke
zburke deleted the STCLI-187 branch November 5, 2021 01:44
mkuklis added a commit that referenced this pull request Nov 5, 2021
mkuklis added a commit that referenced this pull request Nov 5, 2021
Revert "STCLI-187: Update webpack to v5 (#270)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants