Implement interlaced PNG support#1030
Merged
Merged
Conversation
blikblum
changed the title
blikblum
changed the title
Member
Author
|
@devongovett Can you take a look into foliojs/png.js#48 ? There's a few important fixes, together with this one, since last release. |
devongovett
approved these changes
Nov 16, 2019
Member
|
There’s a conflict, but looks good |
Member
|
Released png-js to npm as v1.0.0. Will need to be bumped here. |
Member
Author
|
All done. Thanks |
|
when is it planned to release a new version including this fix? |
|
this gonna be released ? |
Member
Author
|
Already released as v0.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix support for interlaced PNG files.
Fixes #926
Needs foliojs/png.js#48 to work
What is the current behavior?
Interlaced PNG files are draw with garbage
What is the new behavior?
Interlaced PNG files are draw correctly
Checklist: