refactor: decode base64 image data URIs without Buffer - #1759
Merged
Conversation
Adds a fromBase64 helper to binary.js and makes the JPEG parser read headers via the shared readUInt16BE helper, so image data flows as Uint8Array end to end.
diegomura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
image.js/binary.jschanges from diegomura/react-pdf#3400.fromBase64tolib/binary.js(atob+Uint8Array), replacingBuffer.from(match[1], 'base64')inPDFImage.open.this.data.readUInt16BE(...)to the sharedreadUInt16BEhelper it already imports. Without this, the data-URI path throwsthis.data.readUInt16BE is not a function, since the decoded data is now a plainUint8Array.The PNG magic-byte check from that PR is already on
master.Bufferis still used elsewhere inimage.js(Buffer.isBuffer, theArrayBufferbranch) and acrosssecurity.js/object.js/virtual-fs.js, so this removes one usage rather than the dependency.