refactor(server-manager): extract server helpers and modularize PHP stack manager - #7
Merged
Conversation
…erLogger and helper functions
…up and visibility toggling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors
PHPStackManagerto reduce complexity and improve maintainability withinsrc/serverManager.ts. Responsibilities such as logging, router generation, and workspace file visibility management have been decoupled and extracted into dedicated helper modules undersrc/serverHelpers/.Key Changes
ServerLogger(src/serverHelpers/serverLogger.ts):RouterBuilder(src/serverHelpers/routerBuilder.ts):buildRouterContentandgetRouterFilePathlogic out ofserverManager.tsto streamline router script template handling.FileVisibilityHelper (src/serverHelpers/fileVisibility.ts):files.exclude).PHPStackManager(src/serverManager.ts):PHPStackManagerto focus strictly on process lifecycle management (start,stop,restartServer)._cleanup()andstop()methods toasyncto guarantee clean resolution of file visibility changes prior to resource teardown.Verification
ServerLogger.