fix(cli): bundle report templates when installed from crates.io - #877
Merged
Merged
Conversation
Collaborator
|
Thank you! Have been trying to track down this bug for ages and never quite understood it. |
The build script zipped ../templates, which is outside the crate root and therefore missing from the published package; cargo install builds then embedded an empty zip, so ~/.fontspector was never populated and --html/--ghmarkdown failed with TemplateNotFound. Move the templates into the crate so they are packaged, write the zip to a growable buffer instead of a fixed 64KB array (which also embedded trailing zero padding), and fail the build if no templates are found. Fixes fonttools#722, fixes fonttools#119
simoncozens
force-pushed
the
fix/bundled-templates
branch
from
September 4, 2026 09:39
6751782 to
8cb821d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script zipped ../templates, which is outside the crate root and therefore missing from the published package; cargo install builds then embedded an empty zip, so ~/.fontspector was never populated and --html/--ghmarkdown failed with TemplateNotFound. Move the templates into the crate so they are packaged, write the zip to a growable buffer instead of a fixed 64KB array (which also embedded trailing zero padding), and fail the build if no templates are found.
Fixes #722, fixes #119