Skip to content

[#100] feat: code review with skills (/review, /verify-done, /assess-debt)#109

Merged
rucka merged 1 commit into
mainfrom
feature/#100-code-review-skills
Feb 11, 2026
Merged

[#100] feat: code review with skills (/review, /verify-done, /assess-debt)#109
rucka merged 1 commit into
mainfrom
feature/#100-code-review-skills

Conversation

@rucka

@rucka rucka commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

What Changed

Code review skill infrastructure: 3 new SKILL.md files + how-to-11 thinning + /implement PM tool sync fix.

Why This Change

Enable structured, skill-driven code reviews that compose atomic capabilities. Third P0 story in the Agent Skills epic — proves 6-skill composition pattern.

Story Context

User Story: #100 — Code review with skills
Epic: #97 — Agent Skills in Knowledge Base

Changes Made

Implementation Details

  • /verify-done SKILL.md — DoD checker with 8-step algorithm, idempotent skip logic
  • /assess-debt SKILL.md — tech debt flagger stub (severity only, full in Remaining capability skills + /verify-adoption + /next update + prompt deprecation #105)
  • /review SKILL.md — 5-phase process composing 6 atomics (4 required + 2 optional)
  • how-to-11 thinned from 363 to 163 lines (orchestrator only)
  • /implement SKILL.md — added PM tool sync steps (assign+InProgress, task checkbox update)

Files Changed

  • Added: .skills/capability/verify-done/SKILL.md, .skills/capability/assess-debt/SKILL.md, .skills/process/review/SKILL.md
  • Modified: .skills/process/implement/SKILL.md, .pair/knowledge/how-to/11-how-to-code-review.md

Testing

Validation Results

  • All 4 SKILL.md files validated: YAML frontmatter, check→skip→act→verify pattern, composition refs, internal links
  • how-to-11: 163 lines, standalone readable, all links valid
  • Quality gate: PASS (lint, ts:check, tests, prettier)

Key Validation Points

  • /review composes 6 atomic skills correctly (4 required + 2 optional)
  • 4-level graceful degradation cascade documented for all combinations
  • Idempotent re-invocation pattern consistent across all skills
  • HALT on missing ADR propagates correctly
  • /verify-done independently invocable AND composable

Closes #100

@rucka rucka added the user story Work item representing a user story label Feb 11, 2026
@rucka
rucka force-pushed the feature/#100-code-review-skills branch 2 times, most recently from 2185ca2 to 4f4ae90 Compare February 11, 2026 16:37
…debt)

- /verify-done: DoD checker with 8-step algorithm, idempotent skip logic
- /assess-debt: tech debt flagger stub (severity only, full impl in #105)
- /review: 5-phase process composing 6 atomic skills (4 required + 2 optional)
  - 4-level graceful degradation cascade for adoption compliance
  - Output follows code-review-template.md
  - HALT on missing ADR via /record-decision
- how-to-11: thinned 363→163 lines (orchestrator only)
- /implement: PM tool sync, dev confirmation, PR template, ready-for-review

Closes #100
@rucka
rucka force-pushed the feature/#100-code-review-skills branch from 4f4ae90 to 881314b Compare February 11, 2026 16:42
@rucka
rucka merged commit 3d07189 into main Feb 11, 2026
1 check passed
@rucka
rucka deleted the feature/#100-code-review-skills branch February 11, 2026 16:53
@rucka rucka mentioned this pull request Feb 12, 2026
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user story Work item representing a user story

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code review with skills (/review, /verify-done)

1 participant