[#102] feat: bootstrap core skills (/specify-prd, /bootstrap, /setup-pm)#116
Conversation
Tasks are documented inline in the story body only. Removed task issue creation from Step 6, updated /write-issue composition interface accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
VS Code prompts-diagnostics-provider doesn't support YAML multi-line >- syntax. Convert all 30 SKILL.md description fields to single-line quoted strings across dataset, .claude/skills, and apps/pair-cli. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add --dot flag to markdownlint scripts (exposes .pair/, .skills/, .github/) - Scripts accept optional path args, default to **/*.md - Root mdlint:check/fix chains docs/ after turbo packages - Disable MD001, MD024, MD025, MD026, MD046, MD060 (KB patterns) - Fix MD040 (code block language) in 9 docs/ files - Fix MD032 (blanks around lists) via auto-fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4ac3319 to
7c0a364
Compare
rucka
left a comment
There was a problem hiding this comment.
Code Review — #116
Reviewer: AI (pair-process-review)
Date: 2026-02-13
Story: #102 — Bootstrap core with skills
Type: Feature
Review Summary
Overall Assessment
- Approved — Ready to merge
Key Changes
- 3 new SKILL.md files:
/specify-prd(process),/bootstrap(process),/setup-pm(capability) - 2 how-to files thinned to orchestration-only (
01,02) /implementfix: inter-task confirmation added to commit-per-task strategy- Bridge files updated (pair-next, write-issue, GitHub prompts)
Business Value
Completes P1 bootstrap lifecycle with skills. End-to-end project setup now possible via /bootstrap composing /specify-prd and /setup-pm.
Code Review Checklist
Functionality
- Requirements Met — all 10 AC covered (AC-1 through AC-10)
- Business Logic — idempotency (check→skip→act→verify) correct in all 3 skills
- Integration — composition interfaces documented and consistent across skills
- Error Handling — HALT conditions and graceful degradation well-defined
Code Quality
- Readability — clear phase structure, consistent formatting
- Maintainability — skills follow established pattern from #99/#100/#101
- Naming — YAML frontmatter, section headers, output format consistent
- Complexity — /bootstrap is the most complex skill but well-organized with independent phases
Technical Standards
- Style Guide — single-line YAML descriptions, standard SKILL.md structure
- Architecture — skill composition pattern validated at scale (6 composed skills in /bootstrap)
- Dependencies — no new code dependencies; all cross-references valid
Quality Gates
Quality Gate: ✅ All passing (pnpm quality-gate)
├── ts:check: ✅
├── test: ✅
├── lint: ✅
├── prettier:fix: ✅ clean
└── mdlint:fix: ✅ clean
Consistency Checks
- Dataset ↔ Installed copies — all differences are expected name qualifications (short →
pair-process-/pair-capability-prefix) - Cross-references — all relative markdown links resolve to existing files
- Squash policy — single commit on branch ✅
- Commit format —
[#102] feat:follows convention ✅
Positive Feedback
- Hypothesis-driven questioning in
/specify-prdis a great UX pattern — reduces developer effort - Quality gate setup in
/bootstrapPhase 3.2 (executable from day one) is forward-thinking - Inter-task confirmation in
/implementaddresses a real developer experience issue - How-to thinning preserves standalone readability — non-skill assistants can still follow the flow
Minor Issues 💡
-
how-to-02 line count: 115 lines vs target 90±15 (max 105). Over by 10 lines. Consider trimming the categorization table or condensing References section.
-
Trailing slash inconsistency in installed
/bootstrapcopy: directory link targets drop trailing slashes (e.g.,adoption/decision-logvs dataset'sadoption/decision-log/). No functional impact but minor formatting inconsistency.
AC Coverage Verification
| AC | Description | Status |
|---|---|---|
| AC-1 | /specify-prd creates PRD | ✅ Phase 1-4 algorithm |
| AC-2 | /specify-prd idempotent | ✅ Phase 0 detection |
| AC-3 | /bootstrap orchestrates | ✅ Phase 0-4 |
| AC-4 | /bootstrap idempotent | ✅ Phase-level file detection |
| AC-5 | /setup-pm configures | ✅ Steps 2-4 |
| AC-6 | /setup-pm + /record-decision | ✅ Step 5 |
| AC-7 | /setup-pm idempotent | ✅ Step 1 detection |
| AC-8 | /bootstrap + /record-decision | ✅ Phase 1, 2, 3.2 |
| AC-9 | Graceful degradation | ✅ Phase 2 Step 2.2 |
| AC-10 | Thinned how-to readable | ✅ Both standalone-readable |
Decision
APPROVED — No critical or major issues. 2 minor items noted for consideration. All AC met, quality gates pass, patterns consistent with prior stories.
- /specify-prd: PRD creation via template analysis + hypothesis-driven questioning (idempotent) - /setup-pm: PM tool selection, configuration, ADL recording via /record-decision (idempotent) - /bootstrap: full project setup orchestrator composing /specify-prd, /setup-pm, /record-decision, assess-* (optional, graceful degradation) - how-to-01: thinned 222→96 lines (orchestration only, refs /specify-prd) - how-to-02: thinned 251→116 lines (orchestration only, refs /bootstrap + /setup-pm) Refs: #102
7c0a364 to
64286db
Compare
PR Information
Story/Epic: #102 / #97
Type: Feature
Labels: user story
Summary
What Changed
Added 3 new Agent Skills for project bootstrap, thinned 2 how-to files to orchestration-only, and fixed inter-task confirmation behavior in
/implement:/specify-prd— PRD creation process skill (idempotent, hypothesis-driven questioning)/setup-pm— PM tool configuration capability skill (composes /record-decision)/bootstrap— Full project setup orchestrator (composes /specify-prd, /setup-pm, /record-decision, assess-* with graceful degradation)/implementfix — commit-per-task strategy now pauses for developer confirmation after each taskWhy This Change
P1 story enabling end-to-end project bootstrap with skills. Completes the bootstrap lifecycle: PRD creation → project categorization → standards generation → quality gate setup → PM tool configuration. How-to files thinned to orchestrators that delegate operational detail to skills.
Story Context
User Story: #102 — Bootstrap core with skills
Epic: #97 — Agent Skills in Knowledge Base
AC Coverage: All 10 acceptance criteria covered (AC-1 through AC-10)
Changes Made
Implementation Details
/specify-prd: template analysis → hypothesis-driven info gathering → PRD creation → review. Idempotent: detects existing PRD, offers selective update./setup-pm: PM tool selection via decision framework, configuration per implementation guide, ADL recording via /record-decision. Idempotent: detects existing config./bootstrap: phase-level idempotency (PRD → categorization → checklist → standards → quality gates → PM). Graceful degradation when assess-* skills not installed./implement: Step 1.3 updated commit strategy descriptions; Step 2.8 added inter-task confirmation flow (summary → ask → verify → return).Files Changed
Dataset (source of truth):
dataset/.skills/process/specify-prd/SKILL.mddataset/.skills/capability/setup-pm/SKILL.mddataset/.skills/process/bootstrap/SKILL.mddataset/.skills/process/implement/SKILL.md(inter-task confirmation fix)dataset/.pair/knowledge/how-to/01-how-to-create-PRD.md(thinned)dataset/.pair/knowledge/how-to/02-how-to-complete-bootstrap-checklist.md(thinned)Installed copies (.claude/skills/):
.claude/skills/pair-process-specify-prd/SKILL.md.claude/skills/pair-process-bootstrap/SKILL.md.claude/skills/pair-capability-setup-pm/SKILL.md.claude/skills/pair-process-implement/SKILL.md.claude/skills/pair-capability-write-issue/SKILL.md.claude/skills/pair-next/SKILL.mdBridge files:
.pair/knowledge/how-to/01-how-to-create-PRD.md.pair/knowledge/how-to/02-how-to-complete-bootstrap-checklist.md.github/prompts/README.mdTesting
Test Results
Testing Strategy
Quality Assurance
Code Quality Checklist
Review Areas
Reviewer Guide
Review Focus Areas
Key Test Scenarios
Dependencies & Related Work
Prerequisites
Enables
Follow-up
Closes #102