Stabilize Poll Updates and Release Old Catalogue Trees#79
Merged
Conversation
smartinov
force-pushed
the
feature/loader-direct-json-content-type
branch
2 times, most recently
from
f986289 to
ad49cac
Compare
…updates Bumps the gomod-security group with 1 update in the / directory: [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go). Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` from 1.41.0 to 1.43.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.41.0...v1.43.0) Updates `go.opentelemetry.io/otel/sdk` from 1.41.0 to 1.43.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.41.0...v1.43.0) Updates `google.golang.org/grpc` from 1.79.1 to 1.80.0 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.79.1...v1.80.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp dependency-version: 1.43.0 dependency-type: indirect dependency-group: gomod-security - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect dependency-group: gomod-security - dependency-name: google.golang.org/grpc dependency-version: 1.80.0 dependency-type: indirect dependency-group: gomod-security ... Signed-off-by: dependabot[bot] <support@github.com>
smartinov
force-pushed
the
feature/loader-direct-json-content-type
branch
from
c41a362 to
a8e8273
Compare
smartinov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stabilizes poll-mode catalogue updates and keeps the branch ready for merge:
versionfield: ETag when present, otherwise the URL returned by the poll endpoint.go.modandgo.sum.PollRoutinesuccess log path that Coveralls previously reported as the uncovered changed line.Notes
If-None-Match; URL fallback versions are only used for local same-version short-circuiting.golangci-lintstarted flagging unrelated mock helper patterns, so the PR also cleans those up to keep rerun CI deterministic.Review
runtime.GC()is process-wide and intentional for the observed OOM pattern; we do not yet have latency benchmark evidence for the reload pause.Test Plan
go build ./...make testgo test -tags=safe -coverprofile=coverage.out -count=1 ./... && go tool cover -func=coverage.out— total coverage47.5%make lint— localgolangci-lintv2.10.1go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.1 run— current CI latest versiontestpassed, including Coveralls upload step