Sync fork with upstream repo#2
Merged
Merged
Conversation
Ruby 3 and rails 7 support
handle ruby 3.x keyword arguments delegation
Updates CI to support Ruby 3+ and Rails v7
Fix gem publish action
Updates push gem action with a valid ruby version
Write attribute with polymorphic integer type
Should still able to set other reflection successfully
Bump the version to 3.2.2
Upgrade rails to 7.2.x version; clean up unsupported rails and ruby version
ihollander
approved these changes
Jul 1, 2025
ihollander
left a comment
ihollander
left a comment
There was a problem hiding this comment.
Good call dusting this branch off, let's get this up and running again!
|
Leaving a comment to test Slack integration |
Author
|
For future reference, I shouldn't have squashed the commits on this "Sync fork" PR because that caused the commit history of this fork to not include the commit history from the upstream repo 🤦 |
arman-radicle
added a commit
that referenced
this pull request
Jul 23, 2026
…morphic_name guard + regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently working on a bug fix to this library to avoid weird behavior called out in this comment. This PR just gets our fork synced with the main repo, so that we can work off of up-to-date library code. The changes that we had previously added to this fork for Ruby 3 and Rails 7 support were also made to the base repo, so all of the changes here are just changes that were merged to the main repo, but we never pulled into our fork.
For the bug fix I'm working on, I think if we agree on the approach internally, I can open a PR onto the main repo too, but we probably don't want to be blocked on someone external to review, merge, and release that bugfix. To avoid needing to wait on that, we can once again point to this fork instead.