Fix #109: DateUtils.isDST() logic is inverted#115
Merged
thedhanawada merged 1 commit intomasterfrom Mar 20, 2026
Merged
Conversation
isDST() compared current offset against Math.max(janOffset, julOffset), but the maximum offset is the standard (non-DST) offset. DST offset is the minimum. Changed to Math.min() so the function returns true during DST and false during standard time. Fixes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Changed
Math.max()toMath.min()in DateUtils.isDST() (line 500).The DST offset is the minimum of January/July offsets (more negative = further ahead). The previous code compared against
Math.max(), which is the standard (winter) offset, causing the function to returntrueduring standard time andfalseduring DST.Files Changed
core/calendar/DateUtils.js— 1 line changedFixes #109