Skip to content

Fix #109: DateUtils.isDST() logic is inverted #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedhanawada merged 1 commit into from
Mar 20, 2026
Merged

Fix #109: DateUtils.isDST() logic is inverted #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/calendar/DateUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@
const julOffset = DateUtils.getTimezoneOffset(jul, timeZone);
const currentOffset = DateUtils.getTimezoneOffset(date, timeZone);

return Math.max(janOffset, julOffset) === currentOffset;
return Math.min(janOffset, julOffset) === currentOffset;
}

/**
Expand Down Expand Up @@ -542,7 +542,7 @@
const timeStr = `${String(hour).padStart(2, '0')}:${String(minute).padStart(2, '0')}:${String(second).padStart(2, '0')}`;

// Use Intl API to get the UTC time for this local time in the timezone
const formatter = new Intl.DateTimeFormat('en-US', {

Check warning on line 545 in core/calendar/DateUtils.js

View workflow job for this annotation

GitHub Actions / Code Complexity 

'formatter' is assigned a value but never used. Allowed unused vars must match /^_/u

Check warning on line 545 in core/calendar/DateUtils.js

View workflow job for this annotation

GitHub Actions / ESLint 

'formatter' is assigned a value but never used. Allowed unused vars must match /^_/u
timeZone,
year: 'numeric',
month: '2-digit',
Expand Down
Loading